Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1418693005: Fix gcc 4.9.2 signed-compare error. (Closed)

Created:
5 years, 2 months ago by akos.palfi.imgtec
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix gcc 4.9.2 signed-compare error. BUG= Committed: https://crrev.com/f5c227b27dc85cdb011b96358f71c33033d70c6e Cr-Commit-Position: refs/heads/master@{#31497}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/js-inlining.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
akos.palfi.imgtec
Hi guys, Google team, Paul: It fixes a gcc compilation error, PTAL.
5 years, 2 months ago (2015-10-22 18:15:36 UTC) #2
paul.l...
https://codereview.chromium.org/1418693005/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1418693005/diff/1/src/compiler/js-inlining.cc#newcode417 src/compiler/js-inlining.cc:417: DCHECK_EQ(static_cast<int32_t>(parameter_count), nit: ValueOutputCount() is 'int', seems we should cast ...
5 years, 2 months ago (2015-10-22 18:49:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418693005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418693005/20001
5 years, 2 months ago (2015-10-22 18:58:39 UTC) #5
akos.palfi.imgtec
Thanks! Nit is fixed. https://codereview.chromium.org/1418693005/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1418693005/diff/1/src/compiler/js-inlining.cc#newcode417 src/compiler/js-inlining.cc:417: DCHECK_EQ(static_cast<int32_t>(parameter_count), On 2015/10/22 18:49:03, paul.l... ...
5 years, 2 months ago (2015-10-22 18:59:14 UTC) #6
paul.l...
my l-g-t-m wouldn't help. Can one of you guys PTAL?
5 years, 2 months ago (2015-10-22 19:10:21 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 19:19:21 UTC) #9
Michael Achenbach
lgtm (stamp)
5 years, 2 months ago (2015-10-23 07:23:52 UTC) #11
Michael Starzinger
LGTM. Thanks!
5 years, 2 months ago (2015-10-23 07:48:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418693005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418693005/20001
5 years, 2 months ago (2015-10-23 08:19:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-23 08:21:00 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 08:21:35 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5c227b27dc85cdb011b96358f71c33033d70c6e
Cr-Commit-Position: refs/heads/master@{#31497}

Powered by Google App Engine
This is Rietveld 408576698