Adding WebContent-free Download

content/browser/download/download_manager_impl.h

Index: content/browser/download/download_manager_impl.h
diff --git a/content/browser/download/download_manager_impl.h b/content/browser/download/download_manager_impl.h
index 372fd58b6169c8d383653017eedd0426116b0bf6..8da6f9066c57c717f95e41c4d6a81adb93b2c800 100644
--- a/content/browser/download/download_manager_impl.h
+++ b/content/browser/download/download_manager_impl.h
@@ -8,9 +8,11 @@
 #include <map>
 #include <set>
 #include <string>
+#include <vector>
 
 #include "base/callback_forward.h"
 #include "base/containers/hash_tables.h"
+#include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ -18,6 +20,7 @@
 #include "base/sequenced_task_runner_helpers.h"
 #include "base/synchronization/lock.h"
 #include "content/browser/download/download_item_impl_delegate.h"
+#include "content/browser/download/url_downloader.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/download_manager_delegate.h"
@@ -38,6 +41,20 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,
  public:
   typedef base::Callback<void(DownloadItemImpl*)> DownloadItemImplCreated;
 
+  class Core {

[asanka, 2015/12/08 16:58:32]

Core classes are usually used when some core functionality requires a different
lifetime than the main object (E.g. we need a refcounted state to attach to some
async operation whose lifetime we don't control).

In the case of DownloadManagerImpl, it's less of a lifetime issue than it is
thread specificity and doesn't cover the core functionality of DownloadManager.
Shall we call it something else? Maybe something like IOThreadState or
DownloadRequestContainer.

Also, if you just have a vector of owned pointers to off thread objects for the
only purpose of deleting them on the correct thread, you can use something like:

  std::vector<scoped_ptr<UrlDownloader, BrowserThread::DeleteOnIOThread>>
url_downloaders_;

You can then have this object on the UI thread. Of course you'd need to toss a
scoped_ptr<UrlDownloader> back up to the UI thread after it's created and starts
running.

[svaldez, 2015/12/08 20:39:26]

Done.

+   public:
+    Core();
+    ~Core();
+
+    void AddUrlDownloader(scoped_ptr<UrlDownloader> downloader);
+    void Shutdown();
+
+   private:
+    std::vector<scoped_ptr<UrlDownloader>> url_downloaders_;
+
+    DISALLOW_COPY_AND_ASSIGN(Core);
+  };
+
   // Caller guarantees that |net_log| will remain valid
   // for the lifetime of DownloadManagerImpl (until Shutdown() is called).
   DownloadManagerImpl(net::NetLog* net_log, BrowserContext* browser_context);
@@ -168,6 +185,8 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,
   void ShowDownloadInShell(DownloadItemImpl* download) override;
   void DownloadRemoved(DownloadItemImpl* download) override;
 
+  Core* core_;
+
   // Factory for creation of downloads items.
   scoped_ptr<DownloadItemFactory> item_factory_;