third_party/WebKit/Source/platform/graphics/Path.h - Issue 1418663004: SVG animateMotion paths that only cause offsets are no longer ignored

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Path.h

Issue 1418663004: SVG animateMotion paths that only cause offsets are no longer ignored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp ('k') | third_party/WebKit/Source/platform/graphics/Path.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/Path.h

diff --git a/third_party/WebKit/Source/platform/graphics/Path.h b/third_party/WebKit/Source/platform/graphics/Path.h

index bbc1f750baca8c9307378b8e03e747df5b3f7cd9..adcacaec9c6d22adb4740e9a3557b123fd008260 100644

--- a/third_party/WebKit/Source/platform/graphics/Path.h

+++ b/third_party/WebKit/Source/platform/graphics/Path.h

@@ -82,8 +82,8 @@ public:

FloatRect strokeBoundingRect(const StrokeData&) const;

float length() const;

- FloatPoint pointAtLength(float length, bool& ok) const;

- bool pointAndNormalAtLength(float length, FloatPoint&, float&) const;

+ FloatPoint pointAtLength(float length) const;

+ void pointAndNormalAtLength(float length, FloatPoint&, float&) const;

// Helper for computing a sequence of positions and normals (normal angles) on a path.

// The best possible access pattern will be one where the |length| value is

@@ -96,7 +96,7 @@ public:

public:

explicit PositionCalculator(const Path&);

- bool pointAndNormalAtLength(float length, FloatPoint&, float&);

+ void pointAndNormalAtLength(float length, FloatPoint&, float&);

private:

SkPath m_path;