SVG animateMotion paths that only cause offsets are no longer ignored

third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp

 /*
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 235 matching lines @@
 
         transform->translate(animatedX, animatedY);
         return;
     }
 
     ASSERT(!m_animationPath.isEmpty());
 
     float positionOnPath = m_animationPath.length() * percentage;
     FloatPoint position;
     float angle;
-    bool ok = m_animationPath.pointAndNormalAtLength(positionOnPath, position, angle);
-    if (!ok)
-        return;
+    m_animationPath.pointAndNormalAtLength(positionOnPath, position, angle);
 
     // Handle accumulate="sum".
     if (isAccumulated() && repeatCount) {
+        bool ok;
         FloatPoint positionAtEndOfDuration = m_animationPath.pointAtLength(m_animationPath.length(), ok);

[pdr., 2015/10/30 00:52:05]

pointAtLength just calls pointAndNormalAtLength internally. Does this need to be
updated to handle the "M 100 100 L 100 100" case too?

[Eric Willigers, 2015/11/20 07:49:53]

Updated.

animateMotion-still.html now tests this case when time is 2s,3s
(repeatCount==1).

         if (ok)
             position.move(positionAtEndOfDuration.x() * repeatCount, positionAtEndOfDuration.y() * repeatCount);
     }
 
     transform->translate(position.x(), position.y());
     RotateMode rotateMode = this->rotateMode();
     if (rotateMode != RotateAuto && rotateMode != RotateAutoReverse)
         return;
     if (rotateMode == RotateAutoReverse)
         angle += 180;
@@ skipping 43 matching lines @@
 
 void SVGAnimateMotionElement::updateAnimationMode()
 {
     if (!m_animationPath.isEmpty())
         setAnimationMode(PathAnimation);
     else
         SVGAnimationElement::updateAnimationMode();
 }
 
 }