Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Unified Diff: pkg/analyzer/test/src/task/html_test.dart

Issue 1418663002: Issue 24552. Disable reporting HTML parsing errors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/context/context_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/html_test.dart
diff --git a/pkg/analyzer/test/src/task/html_test.dart b/pkg/analyzer/test/src/task/html_test.dart
index a90116545e4d7b8d409c0abcf83f9df75409a22c..0806e907a6b5453fe65a857210c8865354dc2bea 100644
--- a/pkg/analyzer/test/src/task/html_test.dart
+++ b/pkg/analyzer/test/src/task/html_test.dart
@@ -177,6 +177,23 @@ class DartScriptsTaskTest extends AbstractContextTest {
@reflectiveTest
class HtmlErrorsTaskTest extends AbstractContextTest {
+ fail_perform_htmlErrors() {
+ AnalysisTarget target = newSource(
+ '/test.html',
+ r'''
+<html>
+ <head>
+ <title>test page</not-title>
+ </head>
+ <body>
+ Test
+ </body>
+</html>
+''');
+ computeResult(target, HTML_ERRORS, matcher: isHtmlErrorsTask);
+ expect(outputs[HTML_ERRORS], hasLength(1));
+ }
+
test_constructor() {
Source source = newSource('/test.html');
HtmlErrorsTask task = new HtmlErrorsTask(context, source);
@@ -223,23 +240,6 @@ class HtmlErrorsTaskTest extends AbstractContextTest {
expect(outputs[HTML_ERRORS], hasLength(1));
}
- test_perform_htmlErrors() {
- AnalysisTarget target = newSource(
- '/test.html',
- r'''
-<html>
- <head>
- <title>test page</not-title>
- </head>
- <body>
- Test
- </body>
-</html>
-''');
- computeResult(target, HTML_ERRORS, matcher: isHtmlErrorsTask);
- expect(outputs[HTML_ERRORS], hasLength(1));
- }
-
test_perform_noErrors() {
AnalysisTarget target = newSource(
'/test.html',
@@ -303,7 +303,7 @@ class ParseHtmlTaskTest extends AbstractContextTest {
<title>test page</title>
</head>
<body>
- <h1 Test>
+ <h1>Test</h1>
</body>
</html>
''';
@@ -311,7 +311,7 @@ class ParseHtmlTaskTest extends AbstractContextTest {
computeResult(target, HTML_DOCUMENT);
expect(task, isParseHtmlTask);
expect(outputs[HTML_DOCUMENT], isNotNull);
- expect(outputs[HTML_DOCUMENT_ERRORS], isNotEmpty);
+ expect(outputs[HTML_DOCUMENT_ERRORS], isEmpty);
// LINE_INFO
{
LineInfo lineInfo = outputs[LINE_INFO];
« no previous file with comments | « pkg/analyzer/test/src/context/context_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698