[iOS] Support for chrome://version

[iOS] Support for chrome://version

This CL ports chrome://version on iOS.
A helper method to return the list of variations is componentized as
part of this CL to allow sharing the code with other platforms.

Committed: https://crrev.com/09a79c4f21e56f82e9406c300ffab446e1d92bb4
Cr-Commit-Position: refs/heads/master@{#356273}

[droger, 2015-10-26 17:06:59]

droger@chromium.org changed reviewers:
+ blundell@chromium.org, dbeam@chromium.org

[droger, 2015-10-26 17:07:00]

dbeam for:
//components/version_ui
//chrome/browser/ui/webui/version_handler.cc

blundell for:
//ios

[Dan Beam, 2015-10-26 18:44:51]

lgtm as you're basically just moving code

https://codereview.chromium.org/1418653004/diff/20001/components/version_ui/v...
File components/version_ui/version_handler_helper.cc (right):

https://codereview.chromium.org/1418653004/diff/20001/components/version_ui/v...
components/version_ui/version_handler_helper.cc:38: it != variations.end();
++it) {
nit: can we just to for ( : )?

[droger, 2015-10-27 10:06:49]

https://codereview.chromium.org/1418653004/diff/20001/components/version_ui/v...
File components/version_ui/version_handler_helper.cc (right):

https://codereview.chromium.org/1418653004/diff/20001/components/version_ui/v...
components/version_ui/version_handler_helper.cc:38: it != variations.end();
++it) {
On 2015/10/26 18:44:51, Dan Beam wrote:
> nit: can we just to for ( : )?

Done.

[blundell, 2015-10-27 10:10:00]

lgtm

https://codereview.chromium.org/1418653004/diff/40001/ios/chrome/browser/ui/w...
File ios/chrome/browser/ui/webui/version_ui.cc (right):

https://codereview.chromium.org/1418653004/diff/40001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/version_ui.cc:60: // On iOS, shorten the git hash to
display it correctly on small devices.
nit: s/"On iOS, "//

[droger, 2015-10-27 10:19:05]

Thanks for the reviews.

[droger, 2015-10-27 10:19:09]

The CQ bit was checked by droger@chromium.org

[droger, 2015-10-27 10:19:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1418653004/#ps60001
(title: "Review comment from blundell")

[commit-bot: I haz the power, 2015-10-27 10:19:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418653004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418653004/60001

[commit-bot: I haz the power, 2015-10-27 12:02:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-27 12:03:27]

Patchset 4 (id:??) landed as
https://crrev.com/09a79c4f21e56f82e9406c300ffab446e1d92bb4
Cr-Commit-Position: refs/heads/master@{#356273}