Fix warnings on implicit casts

Fix warnings on implicit casts

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/ba6078197ba8093706873569d123cd94aa897308

[vsm, 2015-10-20 22:05:00]

vsm@google.com changed reviewers:
+ leafp@google.com

[vsm, 2015-10-20 22:05:05]

https://codereview.chromium.org/1418653003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/1418653003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:996: mOfDs =
/*warning:DownCastComposite*/lOfAs;
This is the case where we now complain more loudly.

[Leaf, 2015-10-20 22:30:35]

https://codereview.chromium.org/1418653003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong/info.dart (right):

https://codereview.chromium.org/1418653003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong/info.dart:173: if (typeArgs.isEmpty ||
typeArgs.any((t) => t.isDynamic)) {
I don't think we know that fromT is generic here do we?  And I think we only
want to warn if it is?  So for example, if we have:

class A<T extends int> {
   T foo(int x) => x;
}

I think this will give a warning, but if I replace int with List<int> it won't?

[Leaf, 2015-10-20 22:51:11]

On 2015/10/20 22:30:35, Leaf wrote:
>
https://codereview.chromium.org/1418653003/diff/20001/pkg/analyzer/lib/src/ta...
> File pkg/analyzer/lib/src/task/strong/info.dart (right):
> 
>
https://codereview.chromium.org/1418653003/diff/20001/pkg/analyzer/lib/src/ta...
> pkg/analyzer/lib/src/task/strong/info.dart:173: if (typeArgs.isEmpty ||
> typeArgs.any((t) => t.isDynamic)) {
> I don't think we know that fromT is generic here do we?  And I think we only
> want to warn if it is?  So for example, if we have:
> 
> class A<T extends int> {
>    T foo(int x) => x;
> }
> 
> I think this will give a warning, but if I replace int with List<int> it
won't?

Ok, per offline conversation, this is WAI, LGTM.

[vsm, 2015-10-20 23:00:29]

Committed patchset #2 (id:20001) manually as
ba6078197ba8093706873569d123cd94aa897308 (presubmit successful).