Limit interceptedElements to instantiated members only.

Limit interceptedElements to instantiated members only.

BUG=
R=asgerf@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/c71f758cbade6f81cff67c4ddafffdd777159697

Reverted: https://github.com/dart-lang/sdk/commit/25aeab3c40940274d50162d1de931a423b4d4b5e

[Johnni Winther, 2015-11-09 16:18:36]

johnniwinther@google.com changed reviewers:
+ asgerf@google.com

[asgerf, 2015-11-09 16:29:16]

asgerf@google.com changed reviewers:
+ sra@google.com

[asgerf, 2015-11-09 16:29:16]

LGTM. sra do you know if there is any downside to this?

[sra1, 2015-11-11 21:29:19]

On 2015/11/09 16:29:16, asgerf wrote:
> LGTM. sra do you know if there is any downside to this?

An abstract native class may be 'instantiated' because native classes do not
have a fully closed world property.
There may be undeclared classes that are subclasses of the abstract class. The
best we can do is treat them as instances of the abstract class.

So I think that we must permit creating a subclass mask for abstract native
classes.

Is this to fix the problem with GlobalEventHandlers in compiling swarm?

[Johnni Winther, 2015-11-12 09:01:24]

On 2015/11/11 21:29:19, sra1 wrote:
> On 2015/11/09 16:29:16, asgerf wrote:
> > LGTM. sra do you know if there is any downside to this?
> 
> An abstract native class may be 'instantiated' because native classes do not
> have a fully closed world property.
> There may be undeclared classes that are subclasses of the abstract class. The
> best we can do is treat them as instances of the abstract class.
> 
> So I think that we must permit creating a subclass mask for abstract native
> classes.
> 
> Is this to fix the problem with GlobalEventHandlers in compiling swarm?

It fixes the same problem occuring in a dart2js_extra test.

Native classes are considered instantiated even if abstract (see
Universe.registerTypeInstantiation). The registration of the members
GlobalEventHandlers is triggered by JavaScriptBackend._processClass when
GlobalEventHandlers is either instantiated or implemented. The later happen when
for instance HtmlElement (which implements GlobalEventHandlers) is instantiated.
Creating a `subclass type mask of GlobalEventHandlers` is not allowed (because
it is effectively empty). The type masks `subclass of HtmlElement` and `subtype
of GlobalEventHandlers` are allowed (and non-empty) in this scenario.

[sra1, 2015-11-13 22:20:49]

lgtm

[Johnni Winther, 2015-11-16 11:46:36]

Committed patchset #1 (id:1) manually as
c71f758cbade6f81cff67c4ddafffdd777159697 (presubmit successful).

[Johnni Winther, 2015-11-18 10:50:34]

Description was changed from

==========
Limit interceptedElements to instantiated members only.

BUG=
R=asgerf@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c71f758cbade6f81cff67c4ddafffdd777159697
==========

to

==========
Limit interceptedElements to instantiated members only.

BUG=
R=asgerf@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c71f758cbade6f81cff67c4ddafffdd777159697

Reverted:
https://github.com/dart-lang/sdk/commit/25aeab3c40940274d50162d1de931a423b4d4b5e
==========

[asgerf, 2015-11-27 13:26:15]

On 2015/11/16 11:46:36, Johnni Winther wrote:
> Committed patchset #1 (id:1) manually as
> c71f758cbade6f81cff67c4ddafffdd777159697 (presubmit successful).

Has this been recommitted, or is there still a problem?

[Johnni Winther, 2015-11-27 13:31:30]

On 2015/11/27 13:26:15, asgerf wrote:
> On 2015/11/16 11:46:36, Johnni Winther wrote:
> > Committed patchset #1 (id:1) manually as
> > c71f758cbade6f81cff67c4ddafffdd777159697 (presubmit successful).
> 
> Has this been recommitted, or is there still a problem?

It is still a problem (e.g. in swarm). I'm working on a solution.