Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1418643002: [turbofan] Respect effect input when lowering JSToBoolean for string inputs. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Respect effect input when lowering JSToBoolean for string inputs. This allows us to re-enable the mjsunit/tools/profile test case. R=jarin@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/2abd768e873d4e7c53687b8a6707c8b1d1966589 Cr-Commit-Position: refs/heads/master@{#31416}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-4493-1.js View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-20 14:47:41 UTC) #1
Jarin
lgtm
5 years, 2 months ago (2015-10-20 14:54:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418643002/20001
5 years, 2 months ago (2015-10-20 15:04:57 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 15:24:23 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2abd768e873d4e7c53687b8a6707c8b1d1966589 Cr-Commit-Position: refs/heads/master@{#31416}
5 years, 2 months ago (2015-10-20 15:24:47 UTC) #6
Michael Achenbach
4 years, 10 months ago (2016-02-04 10:31:39 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698