Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 141863005: Add standalone drawText for GrTextContext. (Closed)

Created:
6 years, 11 months ago by jvanverth1
Modified:
6 years, 10 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@issue2018-factory
Visibility:
Public.

Description

Add standalone drawText for GrTextContext. This unifies the interface between GrBitmapTextContext and GrDistanceFieldTextContext so that they don't need special case code. The future GrNVPRTextContext will also use this interface. BUG=skia:2018 Committed: http://code.google.com/p/skia/source/detail?r=13227

Patch Set 1 : First pass at getting standalone drawText in GrBitmapTextContext. #

Patch Set 2 : Unify GrTextContext::drawText() interface. #

Patch Set 3 : Unify GrTextContext::drawPosText() interface. #

Patch Set 4 : Some clean-up work. #

Total comments: 4

Patch Set 5 : Remove SkDevice* from TextContext. Fix up some SK_OVERRIDEs. #

Total comments: 2

Patch Set 6 : Don't use SkDeviceProperties pointer #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Remove some unnecessary prototypes and headers #

Patch Set 10 : Remove some unnecessary prototypes and headers #

Patch Set 11 : Remove some unnecessary prototypes and headers #

Patch Set 12 : Fix some Mac errors #

Patch Set 13 : One more Mac compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -158 lines) Patch
M include/core/SkPaint.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrBitmapTextContext.h View 1 2 3 4 5 1 chunk +6 lines, -4 lines 0 comments Download
M include/gpu/GrDistanceFieldTextContext.h View 1 2 3 4 5 1 chunk +7 lines, -12 lines 0 comments Download
M include/gpu/GrTextContext.h View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +31 lines, -20 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +335 lines, -5 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 4 5 4 chunks +21 lines, -11 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 2 3 4 5 6 7 8 2 chunks +51 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 5 chunks +10 lines, -100 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jvanverth1
I've verified that this doesn't affect the GMs, and am waiting on a Perf testbot. ...
6 years, 10 months ago (2014-01-27 21:25:58 UTC) #1
bsalomon
https://codereview.chromium.org/141863005/diff/200001/include/gpu/GrDistanceFieldTextContext.h File include/gpu/GrDistanceFieldTextContext.h (right): https://codereview.chromium.org/141863005/diff/200001/include/gpu/GrDistanceFieldTextContext.h#newcode20 include/gpu/GrDistanceFieldTextContext.h:20: void drawText(const char text[], size_t byteLength, SkScalar x, SkScalar ...
6 years, 10 months ago (2014-01-27 21:51:25 UTC) #2
jvanverth1
On 2014/01/27 21:51:25, bsalomon wrote: > https://codereview.chromium.org/141863005/diff/200001/include/gpu/GrDistanceFieldTextContext.h > File include/gpu/GrDistanceFieldTextContext.h (right): > > https://codereview.chromium.org/141863005/diff/200001/include/gpu/GrDistanceFieldTextContext.h#newcode20 > ...
6 years, 10 months ago (2014-01-28 13:42:19 UTC) #3
jvanverth1
https://codereview.chromium.org/141863005/diff/200001/include/gpu/GrDistanceFieldTextContext.h File include/gpu/GrDistanceFieldTextContext.h (right): https://codereview.chromium.org/141863005/diff/200001/include/gpu/GrDistanceFieldTextContext.h#newcode20 include/gpu/GrDistanceFieldTextContext.h:20: void drawText(const char text[], size_t byteLength, SkScalar x, SkScalar ...
6 years, 10 months ago (2014-01-28 18:05:33 UTC) #4
bsalomon
lgtm Keeping a ptr to the non-ref-counted device properties seems a little dubious. Though, I ...
6 years, 10 months ago (2014-01-28 18:46:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/141863005/340001
6 years, 10 months ago (2014-01-28 20:08:42 UTC) #6
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildSkiaLib http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=1377
6 years, 10 months ago (2014-01-28 20:29:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/141863005/380001
6 years, 10 months ago (2014-01-28 21:23:06 UTC) #8
commit-bot: I haz the power
Change committed as 13227
6 years, 10 months ago (2014-01-28 22:02:11 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 22:03:54 UTC) #10
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698