Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1418623009: Output webkit_version.h into the target_gen_dir. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Output webkit_version.h into the target_gen_dir. And update callers to include it like build/util/webkit_version.h. BUG=None R=brettw@chromium.org Committed: https://crrev.com/c2103c407dbce8f4fb29c4332d87812300a10a57 Cr-Commit-Position: refs/heads/master@{#356401}

Patch Set 1 #

Total comments: 2

Patch Set 2 : include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M build/util/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/user_agent.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
As requested. PTAL
5 years, 1 month ago (2015-10-26 21:46:04 UTC) #1
brettw
lgtm https://codereview.chromium.org/1418623009/diff/1/content/common/user_agent.cc File content/common/user_agent.cc (right): https://codereview.chromium.org/1418623009/diff/1/content/common/user_agent.cc#newcode22 content/common/user_agent.cc:22: #include "build/util/webkit_version.h" // NOLINT Actually, I think you ...
5 years, 1 month ago (2015-10-26 23:29:57 UTC) #2
tfarina
https://codereview.chromium.org/1418623009/diff/1/content/common/user_agent.cc File content/common/user_agent.cc (right): https://codereview.chromium.org/1418623009/diff/1/content/common/user_agent.cc#newcode22 content/common/user_agent.cc:22: #include "build/util/webkit_version.h" // NOLINT On 2015/10/26 23:29:57, brettw wrote: ...
5 years, 1 month ago (2015-10-27 20:12:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418623009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418623009/20001
5 years, 1 month ago (2015-10-27 20:13:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 21:37:41 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 21:38:40 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2103c407dbce8f4fb29c4332d87812300a10a57
Cr-Commit-Position: refs/heads/master@{#356401}

Powered by Google App Engine
This is Rietveld 408576698