Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1418623008: Fix link error with busybox and glibc (Closed)

Created:
5 years, 1 month ago by Sam Clegg
Modified:
5 years, 1 month ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Fix link error with busybox and glibc A recent change to ppapi_simple in the SDK caused the link to start failing. This change fixes the issue and also updates the build system so that all settings are passed in at defconfig time, and also switches to using nacl-spawn rather than ppapi_simple directly. Also, an a simple test. Committed: https://chromium.googlesource.com/external/naclports/+/083908e749b3ab3d0cc1feb61280b057737bd645

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -89 lines) Patch
M ports/busybox/build.sh View 2 chunks +30 lines, -66 lines 0 comments Download
A ports/busybox/defconfig View 1 chunk +45 lines, -0 lines 0 comments Download
D ports/busybox/nacl.patch View 1 chunk +0 lines, -23 lines 0 comments Download
M ports/busybox/pkg_info View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418623008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418623008/20001
5 years, 1 month ago (2015-10-26 19:01:43 UTC) #2
Sam Clegg
5 years, 1 month ago (2015-10-26 19:01:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 19:08:08 UTC) #7
bradn
lgtm
5 years, 1 month ago (2015-10-26 19:09:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418623008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418623008/20001
5 years, 1 month ago (2015-10-26 19:09:26 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 19:10:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/naclports/+/083908e749b3ab3d0cc1fe...

Powered by Google App Engine
This is Rietveld 408576698