Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/mips64/builtins-mips64.cc

Issue 1418623007: [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Do not use kNear jump on x64 Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/mips64/code-stubs-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 1542 matching lines...) Expand 10 before | Expand all | Expand 10 after
1553 1553
1554 // static 1554 // static
1555 void Builtins::Generate_CallFunction(MacroAssembler* masm) { 1555 void Builtins::Generate_CallFunction(MacroAssembler* masm) {
1556 // ----------- S t a t e ------------- 1556 // ----------- S t a t e -------------
1557 // -- a0 : the number of arguments (not including the receiver) 1557 // -- a0 : the number of arguments (not including the receiver)
1558 // -- a1 : the function to call (checked to be a JSFunction) 1558 // -- a1 : the function to call (checked to be a JSFunction)
1559 // ----------------------------------- 1559 // -----------------------------------
1560 1560
1561 Label convert, convert_global_proxy, convert_to_object, done_convert; 1561 Label convert, convert_global_proxy, convert_to_object, done_convert;
1562 __ AssertFunction(a1); 1562 __ AssertFunction(a1);
1563 // TODO(bmeurer): Throw a TypeError if function's [[FunctionKind]] internal 1563 __ ld(a2, FieldMemOperand(a1, JSFunction::kSharedFunctionInfoOffset));
1564 // slot is "classConstructor". 1564
1565 {
1566 Label non_class_constructor;
1567 // Check whether the current function is a classConstructor
1568 __ lbu(a3,
1569 FieldMemOperand(a2, SharedFunctionInfo::kFunctionKindByteOffset));
1570 __ And(at, a3,
1571 Operand(SharedFunctionInfo::kClassConstructorBitsWithinByte));
1572 __ Branch(&non_class_constructor, eq, at, Operand(zero_reg));
1573 // Step: 2, If we call a classConstructor Function throw a TypeError.
1574 {
1575 FrameScope frame(masm, StackFrame::INTERNAL);
1576 __ CallRuntime(Runtime::kThrowConstructorNonCallableError, 0);
1577 }
1578 __ bind(&non_class_constructor);
1579 }
1580
1565 // Enter the context of the function; ToObject has to run in the function 1581 // Enter the context of the function; ToObject has to run in the function
1566 // context, and we also need to take the global proxy from the function 1582 // context, and we also need to take the global proxy from the function
1567 // context in case of conversion. 1583 // context in case of conversion.
1568 // See ES6 section 9.2.1 [[Call]] ( thisArgument, argumentsList) 1584 // See ES6 section 9.2.1 [[Call]] ( thisArgument, argumentsList)
1569 STATIC_ASSERT(SharedFunctionInfo::kNativeByteOffset == 1585 STATIC_ASSERT(SharedFunctionInfo::kNativeByteOffset ==
1570 SharedFunctionInfo::kStrictModeByteOffset); 1586 SharedFunctionInfo::kStrictModeByteOffset);
1571 __ ld(cp, FieldMemOperand(a1, JSFunction::kContextOffset)); 1587 __ ld(cp, FieldMemOperand(a1, JSFunction::kContextOffset));
1572 __ ld(a2, FieldMemOperand(a1, JSFunction::kSharedFunctionInfoOffset));
1573 // We need to convert the receiver for non-native sloppy mode functions. 1588 // We need to convert the receiver for non-native sloppy mode functions.
1574 __ lbu(a3, FieldMemOperand(a2, SharedFunctionInfo::kNativeByteOffset)); 1589 __ lbu(a3, FieldMemOperand(a2, SharedFunctionInfo::kNativeByteOffset));
1575 __ And(at, a3, Operand((1 << SharedFunctionInfo::kNativeBitWithinByte) | 1590 __ And(at, a3, Operand((1 << SharedFunctionInfo::kNativeBitWithinByte) |
1576 (1 << SharedFunctionInfo::kStrictModeBitWithinByte))); 1591 (1 << SharedFunctionInfo::kStrictModeBitWithinByte)));
1577 __ Branch(&done_convert, ne, at, Operand(zero_reg)); 1592 __ Branch(&done_convert, ne, at, Operand(zero_reg));
1578 { 1593 {
1579 __ dsll(at, a0, kPointerSizeLog2); 1594 __ dsll(at, a0, kPointerSizeLog2);
1580 __ daddu(at, sp, at); 1595 __ daddu(at, sp, at);
1581 __ ld(a3, MemOperand(at)); 1596 __ ld(a3, MemOperand(at));
1582 1597
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
1922 } 1937 }
1923 } 1938 }
1924 1939
1925 1940
1926 #undef __ 1941 #undef __
1927 1942
1928 } // namespace internal 1943 } // namespace internal
1929 } // namespace v8 1944 } // namespace v8
1930 1945
1931 #endif // V8_TARGET_ARCH_MIPS64 1946 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/mips64/code-stubs-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698