Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2236)

Unified Diff: snapshot/module_snapshot.h

Issue 1418613013: Capture UUID age field on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/minidump/module_snapshot_minidump.cc ('k') | snapshot/test/test_module_snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/module_snapshot.h
diff --git a/snapshot/module_snapshot.h b/snapshot/module_snapshot.h
index d8f1ae6bd92f81a00b54dde1d2707eb228ee5564..6c397ed0a71e6210f988807d8ffea5e9b14ff340 100644
--- a/snapshot/module_snapshot.h
+++ b/snapshot/module_snapshot.h
@@ -109,11 +109,16 @@ class ModuleSnapshot {
//! \brief Returns the module’s type.
virtual ModuleType GetModuleType() const = 0;
- //! \brief Returns the module’s UUID in the \a uuid parameter.
+ //! \brief Returns the module’s UUID in the \a uuid parameter, and the age of
+ //! that UUID in \a age.
//!
//! A snapshot module’s UUID is taken directly from the module itself. If the
//! module does not have a UUID, the \a uuid parameter will be zeroed out.
- virtual void UUID(crashpad::UUID* uuid) const = 0;
+ //!
+ //! \a age is the number of times the UUID has been reused. This occurs on
+ //! Windows with incremental linking. On other platforms \a age will always be
+ //! `0`.
+ virtual void UUIDAndAge(crashpad::UUID* uuid, uint32_t* age) const = 0;
//! \brief Returns string annotations recorded in the module.
//!
« no previous file with comments | « snapshot/minidump/module_snapshot_minidump.cc ('k') | snapshot/test/test_module_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698