Issue 1418613013: Capture UUID age field on Windows

Issue 1418613013: Capture UUID age field on Windows (Closed)

Created:
5 years, 1 month ago by scottmg

Modified:
5 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Capture UUID age field on Windows R=mark@chromium.org BUG=chromium:546288 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a96f5ace5b366dda97adebaa5feafe4661695d86

Patch Set 3 : fixes #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -21 lines)			Patch
M	minidump/minidump_module_writer.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	minidump/minidump_module_writer_test.cc	View		8 chunks	+10 lines, -4 lines	0 comments	Download
M	snapshot/mac/module_snapshot_mac.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	snapshot/mac/module_snapshot_mac.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	snapshot/minidump/module_snapshot_minidump.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	snapshot/minidump/module_snapshot_minidump.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	snapshot/module_snapshot.h	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	snapshot/test/test_module_snapshot.h	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	snapshot/test/test_module_snapshot.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	snapshot/win/module_snapshot_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	snapshot/win/module_snapshot_win.cc	View	1 2	1 chunk	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/1418613013/diff/20001/snapshot/mac/module_snapshot_mac.cc File snapshot/mac/module_snapshot_mac.cc (right): https://codereview.chromium.org/1418613013/diff/20001/snapshot/mac/module_snapshot_mac.cc#newcode155 snapshot/mac/module_snapshot_mac.cc:155: *age = 0; Since this function returns void, ...

5 years, 1 month ago (2015-10-27 20:02:28 UTC) #2

scottmg

Thanks https://codereview.chromium.org/1418613013/diff/20001/snapshot/mac/module_snapshot_mac.cc File snapshot/mac/module_snapshot_mac.cc (right): https://codereview.chromium.org/1418613013/diff/20001/snapshot/mac/module_snapshot_mac.cc#newcode155 snapshot/mac/module_snapshot_mac.cc:155: *age = 0; On 2015/10/27 20:02:27, Mark Mentovai ...

5 years, 1 month ago (2015-10-27 20:06:12 UTC) #3

scottmg

5 years, 1 month ago (2015-10-27 20:07:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
a96f5ace5b366dda97adebaa5feafe4661695d86 (presubmit successful).

Expand Messages | Collapse Messages