Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1418593005: Refine "[test] Skip webkit test too slow for ppc." (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refine "[test] Skip webkit test too slow for ppc." Skip only for simulator runs. R=machenbach@chromium.org BUG= Committed: https://crrev.com/ac4eaee4b13b229555b8c35fb39b92c56124028c Cr-Commit-Position: refs/heads/master@{#31418}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/webkit/webkit.status View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 2 months ago (2015-10-20 13:41:55 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/1418593005/diff/1/test/webkit/webkit.status File test/webkit/webkit.status (right): https://codereview.chromium.org/1418593005/diff/1/test/webkit/webkit.status#newcode50 test/webkit/webkit.status:50: ['simulator', { Hmm - could this be a ...
5 years, 2 months ago (2015-10-20 13:47:07 UTC) #2
MTBrandyberry
On 2015/10/20 13:47:07, Michael Achenbach wrote: > lgtm > > https://codereview.chromium.org/1418593005/diff/1/test/webkit/webkit.status > File test/webkit/webkit.status (right): ...
5 years, 2 months ago (2015-10-20 13:59:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418593005/1
5 years, 2 months ago (2015-10-20 13:59:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 15:26:40 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 15:27:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac4eaee4b13b229555b8c35fb39b92c56124028c
Cr-Commit-Position: refs/heads/master@{#31418}

Powered by Google App Engine
This is Rietveld 408576698