Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1418573011: dart2js: Change how super tear-offs are registered. (Closed)

Created:
5 years, 1 month ago by asgerf
Modified:
5 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Change how super tear-offs are registered. Previously, torn off super methods would be registered by emulating a dynamic getter call using an exact TypeMask for the super class as the receiver. If the super class was abstract (or just not instantiated), using an exact TypeMask is absurd since there are no objects with that exact class. Now, methods that have been registered as "needing super getter" are always considered to have their getter invoked, removing the need to emulate the dynamic getter call. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/a32a12f9000112414e7cf1b65e86e43dc2027d65

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Merge #

Patch Set 4 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 2 3 1 chunk +8 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 1 month ago (2015-10-28 15:10:12 UTC) #2
Johnni Winther
lgtm
5 years, 1 month ago (2015-10-28 16:46:00 UTC) #3
asgerf
5 years, 1 month ago (2015-11-06 10:49:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
a32a12f9000112414e7cf1b65e86e43dc2027d65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698