build/install-build-deps-android.sh - Issue 1418573010: Enable downloading Google Play services via deps hook

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/install-build-deps-android.sh

Issue 1418573010: Enable downloading Google Play services via deps hook (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on master Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/install-build-deps-android.sh

diff --git a/build/install-build-deps-android.sh b/build/install-build-deps-android.sh

index cf873811131633b68525736780ac0dcc3e0b8ff6..9c3692c7d127df6de7ec1d15669f0e2f5e6bd260 100755

--- a/build/install-build-deps-android.sh

+++ b/build/install-build-deps-android.sh

@@ -13,11 +13,10 @@

# past the curses-based dialog press TAB <ret> TAB <ret> to agree.

args="$@"

+# TODO(dgn) remove this this argument from calls (http://crbug.com/541727)

if test "$1" = "--skip-sdk-packages"; then

- skip_inst_sdk_packages=1

args="${@:2}"

-else

- skip_inst_sdk_packages=0

if ! uname -m | egrep -q "i686|x86_64"; then

@@ -92,9 +91,4 @@ then

-# Install SDK packages for android

-if test "$skip_inst_sdk_packages" != 1; then

- "$(dirname "${BASH_SOURCE[0]}")/install-android-sdks.sh"

-fi

echo "install-build-deps-android.sh complete."

« no previous file with comments | « build/install-android-sdks.sh ('k') | build/secondary/third_party/android_tools/BUILD.gn » ('j') | no next file with comments »