Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/analyzer/tool/task_dependency_graph/generate.dart

Issue 1418573004: Add temporary code to debug windows bot failures. (Closed) Base URL: sso://user/paulberry/dart@investigate-codegen-error
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/tool/task_dependency_graph/generate.dart
diff --git a/pkg/analyzer/tool/task_dependency_graph/generate.dart b/pkg/analyzer/tool/task_dependency_graph/generate.dart
index 235c2b9d032b7bee4592cab847b620d9135478b9..d53d81338de26101a92c0ab5748df9b57e8a34db 100644
--- a/pkg/analyzer/tool/task_dependency_graph/generate.dart
+++ b/pkg/analyzer/tool/task_dependency_graph/generate.dart
@@ -32,6 +32,7 @@ import 'package:analyzer/src/generated/sdk_io.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/source_io.dart';
import 'package:path/path.dart' as path;
+import 'dart:convert';
/**
* Generate the target .dot file.
@@ -72,6 +73,12 @@ class Driver {
// Normalize Windows line endings to Unix line endings so that the
// comparison doesn't fail on Windows.
actualContents = actualContents.replaceAll('\r\n', '\n');
+ if (expectedContents != actualContents) {
+ // Print additional information for debugging.
+ // TODO(paulberry): eliminate this when it is no longer needed.
+ print('expected: ${JSON.encode(expectedContents)}');
+ print('actual: ${JSON.encode(actualContents)}');
+ }
return expectedContents == actualContents;
}
@@ -189,7 +196,8 @@ class Driver {
resultLists.add(input);
lines.add(' $input -> $task');
});
- findResultDescriptors(cls.getField('DESCRIPTOR').computeNode(), (String out) {
+ findResultDescriptors(cls.getField('DESCRIPTOR').computeNode(),
+ (String out) {
results.add(out);
lines.add(' $task -> $out');
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698