Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1418563002: Restore null error listener (Closed)

Created:
5 years, 2 months ago by vsm
Modified:
5 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restore null error listener This gets server mode running again. Looks like this was lost in recent refactoring. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/07f08d15d0bf8e742e2eabe6d7d2015546cbef3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lib/src/compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
5 years, 2 months ago (2015-10-19 23:16:36 UTC) #3
Jennifer Messerly
lgtm
5 years, 2 months ago (2015-10-19 23:18:01 UTC) #4
vsm
5 years, 2 months ago (2015-10-19 23:22:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07f08d15d0bf8e742e2eabe6d7d2015546cbef3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698