Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1418543006: Make component_unittests run the same tests on GYP and GN on Android (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 1 month ago
Reviewers:
sdefresne, Sami
CC:
chromium-reviews, darin-cc_chromium.org, jam, scheduler-bugs_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make component_unittests run the same tests on GYP and GN on Android BUG=510485 R=skyostil TBR=sdefresne Committed: https://crrev.com/5927208e019e3d94ae008075f9165eef9ffe33c0 Cr-Commit-Position: refs/heads/master@{#356911}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -48 lines) Patch
M components/BUILD.gn View 1 2 4 chunks +12 lines, -10 lines 0 comments Download
M components/data_use_measurement/content/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/BUILD.gn View 1 2 1 chunk +16 lines, -12 lines 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/scheduler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/sessions/BUILD.gn View 1 2 1 chunk +23 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pkotwicz
blundell@ can you please take a look? I did not add error_reporter_unittest.cc to the GN ...
5 years, 1 month ago (2015-10-26 23:56:07 UTC) #2
blundell
blundell -> sdefresne Sylvain is a better reviewer than me for this, as he's involved ...
5 years, 1 month ago (2015-10-27 08:30:28 UTC) #4
Sami
components/scheduler lgtm, thanks for the fix!
5 years, 1 month ago (2015-10-27 09:58:14 UTC) #6
pkotwicz
sdefresne@ Ping!
5 years, 1 month ago (2015-10-28 20:01:04 UTC) #7
sdefresne
l-g-t-m but please rebase to get iOS fixes in components/sessions/BUILD.gn https://codereview.chromium.org/1418543006/diff/20001/components/sessions/BUILD.gn File components/sessions/BUILD.gn (left): https://codereview.chromium.org/1418543006/diff/20001/components/sessions/BUILD.gn#oldcode153 ...
5 years, 1 month ago (2015-10-29 10:42:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418543006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418543006/40001
5 years, 1 month ago (2015-10-29 18:17:10 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-29 19:29:21 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5927208e019e3d94ae008075f9165eef9ffe33c0 Cr-Commit-Position: refs/heads/master@{#356911}
5 years, 1 month ago (2015-10-29 19:30:03 UTC) #14
sdefresne
5 years, 1 month ago (2015-10-30 09:40:41 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698