Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1418533009: X87: [builtins] Make sure argument count is always valid for C++ builtins. (Closed)

Created:
5 years, 2 months ago by zhengxing.li
Modified:
5 years, 2 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Make sure argument count is always valid for C++ builtins. port 9c8262f11e3d6359874a63f25a31c6ddfba3dc1c (r31120). original commit message: When calling into C++ builtins, we need to make sure that the argument count register contains the correct number of arguments, otherwise the CEntryStub will not be able to leave the stack in the correct state. BUG= Committed: https://crrev.com/b64c1f02ad9a42337bfcb306f02fd2709f7b38b1 Cr-Commit-Position: refs/heads/master@{#31503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 2 months ago (2015-10-23 09:06:10 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-10-23 09:11:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418533009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418533009/1
5 years, 2 months ago (2015-10-23 09:11:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 09:42:49 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 09:43:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b64c1f02ad9a42337bfcb306f02fd2709f7b38b1
Cr-Commit-Position: refs/heads/master@{#31503}

Powered by Google App Engine
This is Rietveld 408576698