Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Issue 1418533005: Add event to media log if origin changes during playback (Closed)

Created:
5 years, 2 months ago by jrummell
Modified:
5 years, 2 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add event to media log if origin changes during playback As this issue has happened at least twice, add a entry in chrome://media-internals so that an origin change that is not allowed is noted in the logs to simplify debugging the issue. BUG=532569, 544911 TEST=entry added when using test case from 544911 Committed: https://crrev.com/66282c1dd37989c997962c2bd1d232cef0354418 Cr-Commit-Position: refs/heads/master@{#355484}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M media/blink/buffered_data_source.cc View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jrummell
PTAL. I suspect this will conflict with your changes.
5 years, 2 months ago (2015-10-21 21:49:08 UTC) #2
DaleCurtis
Thanks! You'll need to rebase, but lgtm!
5 years, 2 months ago (2015-10-22 00:59:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418533005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418533005/20001
5 years, 2 months ago (2015-10-22 02:42:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 02:52:33 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 02:53:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66282c1dd37989c997962c2bd1d232cef0354418
Cr-Commit-Position: refs/heads/master@{#355484}

Powered by Google App Engine
This is Rietveld 408576698