chrome/android/java/res/values-v17/styles.xml - Issue 141853007: Update the AppBannerView appearance

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 141853007: Update the AppBannerView appearance (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Another update for tablets Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/android/java/res/values-sw600dp-v17/styles.xml ('K') | « chrome/android/java/res/values-sw600dp/dimens.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <resources>	7 <resources>
	newt (away) 2014/02/19 21:52:49 I'd dedupe this file and values-h720dp-v17/styles. I'd dedupe this file and values-h720dp-v17/styles.xml. Change the font sizes in this file to @dimen/whatever_font_size, define different font sizes depending on the screen size, and delete values-h720dp-v17/styles.xml. gone 2014/02/19 23:31:43 Nuked. Show quoted text On 2014/02/19 21:52:49, newt wrote: > I'd dedupe this file and values-h720dp-v17/styles.xml. Change the font sizes in > this file to @dimen/whatever_font_size, define different font sizes depending on > the screen size, and delete values-h720dp-v17/styles.xml. Nuked.
8 <style name="AppBannerTitle">	8 <style name="AppBannerTitle">

9 <item name="android:textColor">#333333</item>	9 <item name="android:textColor">#333333</item>

10 <item name="android:textSize">16sp</item>	10 <item name="android:textSize">20sp</item>

11 <item name="android:fontFamily">sans-serif-light</item>	11 <item name="android:fontFamily">sans-serif-light</item>

12 </style>	12 </style>

13 <style name="AppBannerInstallButton">	13 <style name="AppBannerInstallButton">

14 <item name="android:textColor">#ffffff</item>	14 <item name="android:textColor">#ffffff</item>

15 <item name="android:textSize">12sp</item>	15 <item name="android:textSize">14sp</item>

16 <item name="android:textAllCaps">true</item>	16 <item name="android:textAllCaps">true</item>

17 <item name="android:fontFamily">sans-serif</item>	17 <item name="android:fontFamily">sans-serif</item>

18 <item name="android:textStyle">bold</item>	18 <item name="android:textStyle">bold</item>

	19 </style>

	20 <style name="AppBannerOpenButton">
	newt (away) 2014/02/19 21:52:49 you can use style inheritance to here to ensure th you can use style inheritance to here to ensure that AppBannerOpenButton and AppBannerInstallButton are the same, except for color. E.g. <style name="AppBannerOpenButton" parent="@style/AppBannerInstallButton"> <item name="android:textColor">#737373</item> </style> Or define a comment parent and let both styles inherit from that. OR... have a single style called "AppBannerButton" and set the color of each button independently. gone 2014/02/19 23:31:43 Implemented the last bit. Show quoted text On 2014/02/19 21:52:49, newt wrote: > you can use style inheritance to here to ensure that AppBannerOpenButton and > AppBannerInstallButton are the same, except for color. E.g. > > <style name="AppBannerOpenButton" parent="@style/AppBannerInstallButton"> > <item name="android:textColor">#737373</item> > </style> > > Or define a comment parent and let both styles inherit from that. > > OR... have a single style called "AppBannerButton" and set the color of each > button independently. Implemented the last bit.
	21 <item name="android:textColor">#737373</item>

	22 <item name="android:textSize">14sp</item>

	23 <item name="android:textAllCaps">true</item>

	24 <item name="android:fontFamily">sans-serif</item>

	25 <item name="android:textStyle">bold</item>

19 </style>	26 </style>

20 </resources>	27 </resources>

OLD	NEW