Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 //===- subzero/src/IceFixups.h - Assembler fixup kinds ----------*- C++ -*-===// | 1 //===- subzero/src/IceFixups.h - Assembler fixup kinds ----------*- C++ -*-===// |
| 2 // | 2 // |
| 3 // The Subzero Code Generator | 3 // The Subzero Code Generator |
| 4 // | 4 // |
| 5 // This file is distributed under the University of Illinois Open Source | 5 // This file is distributed under the University of Illinois Open Source |
| 6 // License. See LICENSE.TXT for details. | 6 // License. See LICENSE.TXT for details. |
| 7 // | 7 // |
| 8 //===----------------------------------------------------------------------===// | 8 //===----------------------------------------------------------------------===// |
| 9 /// | 9 /// |
| 10 /// \file | 10 /// \file |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 38 void set_kind(FixupKind Kind) { kind_ = Kind; } | 38 void set_kind(FixupKind Kind) { kind_ = Kind; } |
| 39 | 39 |
| 40 RelocOffsetT offset() const; | 40 RelocOffsetT offset() const; |
| 41 IceString symbol(const GlobalContext *Ctx) const; | 41 IceString symbol(const GlobalContext *Ctx) const; |
| 42 | 42 |
| 43 static const Constant *NullSymbol; | 43 static const Constant *NullSymbol; |
| 44 bool isNullSymbol() const { return value_ == NullSymbol; } | 44 bool isNullSymbol() const { return value_ == NullSymbol; } |
| 45 | 45 |
| 46 void set_value(const Constant *Value) { value_ = Value; } | 46 void set_value(const Constant *Value) { value_ = Value; } |
| 47 | 47 |
| 48 void emit(GlobalContext *Ctx, RelocOffsetT OverrideOffset) const; | 48 // Emits fixup, then returns the number of bytes to skip. |
|
Jim Stichnoth
2015/10/21 01:13:38
Use /// doxygen style comment?
Karl
2015/10/22 15:20:53
Done.
| |
| 49 virtual size_t emit(GlobalContext *Ctx, RelocOffsetT OverrideOffset, | |
| 50 bool IsPCRel) const; | |
| 49 | 51 |
| 50 private: | 52 private: |
| 51 intptr_t position_ = 0; | 53 intptr_t position_ = 0; |
| 52 FixupKind kind_ = 0; | 54 FixupKind kind_ = 0; |
| 53 const Constant *value_ = nullptr; | 55 const Constant *value_ = nullptr; |
| 54 }; | 56 }; |
| 55 | 57 |
| 58 /// Extends a fixup to be a textual. That is, it emits text instead of a | |
|
Jim Stichnoth
2015/10/21 01:13:38
I would say s/to be a/to be/ .
Karl
2015/10/22 15:20:53
Done.
| |
| 59 /// sequence of bytes. This class is used to implement unimplemented emitIAS | |
|
Jim Stichnoth
2015/10/21 01:13:38
maybe "as a fallback for" instead of "to implement
Karl
2015/10/22 15:20:53
Done.
| |
| 60 /// methods, allowing them to generate compilable assembly code. | |
| 61 class AssemblerTextFixup : public AssemblerFixup { | |
|
Jim Stichnoth
2015/10/21 01:13:38
Delete default copy ctor, assignment operator, etc
Karl
2015/10/22 15:20:53
Done.
| |
| 62 public: | |
| 63 AssemblerTextFixup(const std::string &Message, size_t NumBytes) | |
| 64 : AssemblerFixup(), Message(Message), NumBytes(NumBytes) {} | |
| 65 ~AssemblerTextFixup() = default; | |
| 66 virtual size_t emit(GlobalContext *Ctx, RelocOffsetT OverrideOffset, | |
| 67 bool isPcRel) const; | |
| 68 | |
| 69 private: | |
| 70 const std::string Message; | |
| 71 const size_t NumBytes; | |
| 72 }; | |
| 73 | |
| 56 using FixupList = std::vector<AssemblerFixup>; | 74 using FixupList = std::vector<AssemblerFixup>; |
| 57 using FixupRefList = std::vector<AssemblerFixup *>; | 75 using FixupRefList = std::vector<AssemblerFixup *>; |
| 58 | 76 |
| 59 } // end of namespace Ice | 77 } // end of namespace Ice |
| 60 | 78 |
| 61 #endif // SUBZERO_SRC_ICEFIXUPS_H | 79 #endif // SUBZERO_SRC_ICEFIXUPS_H |
| OLD | NEW |