Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1418513011: Add new XBox 360 Wireless USB ID. (Closed)

Created:
5 years, 2 months ago by mjbauer
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new XBox 360 Wireless USB ID. Newer 360 controllers have the product ID of 0719. Adding this to chromium enables standard mapping to be performed. Without it, buttons will behave differently than defined in the GamePad API standard mapping. Committed: https://crrev.com/21a97db383613682082fb9b1c5860888cc8b2cfc Cr-Commit-Position: refs/heads/master@{#356244}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix 80 chars issue #

Patch Set 3 : Add to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings_linux.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings_mac.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
mjbauer
This is a fairly simple change. Just adds another product ID to the list for ...
5 years, 2 months ago (2015-10-24 20:49:06 UTC) #2
scottmg
lgtm https://codereview.chromium.org/1418513011/diff/1/content/browser/gamepad/gamepad_standard_mappings_linux.cc File content/browser/gamepad/gamepad_standard_mappings_linux.cc (right): https://codereview.chromium.org/1418513011/diff/1/content/browser/gamepad/gamepad_standard_mappings_linux.cc#newcode236 content/browser/gamepad/gamepad_standard_mappings_linux.cc:236: {"045e", "028f", MapperXInputStyleGamepad}, // Xbox 360 Wireless Controller ...
5 years, 2 months ago (2015-10-25 02:40:07 UTC) #3
mjbauer
On 2015/10/25 02:40:07, scottmg wrote: > lgtm > > https://codereview.chromium.org/1418513011/diff/1/content/browser/gamepad/gamepad_standard_mappings_linux.cc > File content/browser/gamepad/gamepad_standard_mappings_linux.cc (right): > ...
5 years, 1 month ago (2015-10-25 20:19:01 UTC) #4
scottmg
On 2015/10/25 20:19:01, mjbauer95 wrote: > On 2015/10/25 02:40:07, scottmg wrote: > > lgtm > ...
5 years, 1 month ago (2015-10-26 16:19:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418513011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418513011/20001
5 years, 1 month ago (2015-10-26 16:20:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/112648)
5 years, 1 month ago (2015-10-26 16:29:02 UTC) #12
scottmg
On 2015/10/26 16:29:02, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-10-26 16:30:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418513011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418513011/40001
5 years, 1 month ago (2015-10-27 06:01:32 UTC) #16
mjbauer
On 2015/10/26 16:30:07, scottmg wrote: > On 2015/10/26 16:29:02, commit-bot: I haz the power wrote: ...
5 years, 1 month ago (2015-10-27 06:01:35 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-27 06:35:37 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/21a97db383613682082fb9b1c5860888cc8b2cfc Cr-Commit-Position: refs/heads/master@{#356244}
5 years, 1 month ago (2015-10-27 06:36:25 UTC) #19
scottmg
5 years, 1 month ago (2015-10-27 16:29:31 UTC) #20
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698