Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1418513007: Move find_depot_tools.py to build/ (Closed)

Created:
5 years, 2 months ago by Roland McGrath
Modified:
5 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move find_depot_tools.py to build/ build/vs_toolchain.py requires find_depot_tools.py, but it's not available to a project that gets build/ via DEPS and does not also get all of tools/ via DEPS. The native_client repo needs to use build/vs_toolchain.py, but it does not copy chromium/src/tools/ and it should not have to duplicate find_depot_tools.py just to use build/vs_toolchain.py. The native_client repo also needs a standalone script to print out the depot_tools directory location, and find_depot_tools.py can serve that purpose too with some trivial additions. BUG=512869 R=ben@chromium.org, dbeam@chromium.org, dpranke@chromium.org, jbudorick@chromium.org, klundberg@chromium.org, phajdan.jr@chromium.org, sky@chromium.org, tbreisacher@chromium.org Committed: https://crrev.com/b729cfa517895b9ea99c98a8b23f1a811772ba5b Cr-Commit-Position: refs/heads/master@{#356141}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -62 lines) Patch
M build/download_gold_plugin.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/download_sdk_extras.py View 2 chunks +1 line, -2 lines 0 comments Download
A + build/find_depot_tools.py View 1 3 chunks +16 lines, -1 line 0 comments Download
M build/vs_toolchain.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_dev_style/closure_lint_test.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_dev_style/css_checker_test.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_dev_style/html_checker_test.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_dev_style/js_checker_test.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_dev_style/resource_checker_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ispy/client/boto_bucket.py View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/upload_service.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/copyright_scanner/copyright_scanner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/find_depot_tools.py View 1 chunk +0 lines, -45 lines 0 comments Download
M tools/roll_angle.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/roll_webrtc.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/safely-roll-deps.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (6 generated)
Roland McGrath
5 years, 2 months ago (2015-10-23 20:48:38 UTC) #1
Dan Beam
"many reviewers means little reviewing" - ancient proverb
5 years, 2 months ago (2015-10-23 20:57:41 UTC) #2
Roland McGrath
On 2015/10/23 20:57:41, Dan Beam wrote: > "many reviewers means little reviewing" - ancient proverb ...
5 years, 2 months ago (2015-10-23 20:58:41 UTC) #3
Roland McGrath
OK, I guess I was being stupid about the OWNERS files. So I really only ...
5 years, 2 months ago (2015-10-23 21:03:59 UTC) #4
Dirk Pranke
this basically lgtm . I have one minor nit and I think there's one change ...
5 years, 2 months ago (2015-10-23 22:07:53 UTC) #5
Roland McGrath
https://codereview.chromium.org/1418513007/diff/1/build/find_depot_tools.py File build/find_depot_tools.py (right): https://codereview.chromium.org/1418513007/diff/1/build/find_depot_tools.py#newcode10 build/find_depot_tools.py:10: This can also be used as a standlone script ...
5 years, 2 months ago (2015-10-23 22:55:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418513007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418513007/20001
5 years, 2 months ago (2015-10-24 08:02:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/112495)
5 years, 2 months ago (2015-10-24 08:09:09 UTC) #11
Dan Beam
web_dev_style lgtm if it helps
5 years, 2 months ago (2015-10-24 18:27:58 UTC) #12
Paweł Hajdan Jr.
LGTM
5 years, 1 month ago (2015-10-26 12:55:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418513007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418513007/20001
5 years, 1 month ago (2015-10-26 18:53:07 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/112705)
5 years, 1 month ago (2015-10-26 19:05:24 UTC) #17
Ben Goodger (Google)
mojo lgtm
5 years, 1 month ago (2015-10-26 20:28:12 UTC) #18
sky
LGTM
5 years, 1 month ago (2015-10-26 20:57:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418513007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418513007/20001
5 years, 1 month ago (2015-10-26 21:08:16 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 22:07:57 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b729cfa517895b9ea99c98a8b23f1a811772ba5b Cr-Commit-Position: refs/heads/master@{#356141}
5 years, 1 month ago (2015-10-26 22:08:37 UTC) #23
bcwhite
Be careful moving this file. There are three files with the same name but somewhat ...
5 years, 1 month ago (2015-10-29 13:56:54 UTC) #24
tfarina
5 years, 1 month ago (2015-11-01 01:26:24 UTC) #25
Message was sent while issue was closed.
Did this break on WebRTC?

I got this:

    import find_depot_tools
ImportError: No module named find_depot_tools

Powered by Google App Engine
This is Rietveld 408576698