Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: test/paper_checkbox_test.dart

Issue 1418513006: update elements and fix some bugs (Closed) Base URL: git@github.com:dart-lang/polymer_elements.git@master
Patch Set: code review updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/paper_button_test.dart ('k') | test/paper_checked_element_behavior_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/paper_checkbox_test.dart
diff --git a/test/paper_checkbox_test.dart b/test/paper_checkbox_test.dart
index 776bc3d904b6267faa46c46cf351a9a411f55e24..deee4c499aecb45e78f68115acf826809cb83351 100644
--- a/test/paper_checkbox_test.dart
+++ b/test/paper_checkbox_test.dart
@@ -75,16 +75,6 @@ main() async {
c1.checked = true;
expect(c1.validate(null), isTrue);
});
-
- test('checkbox label can be updated', () {
- Polymer.dom(c1).text = 'Batman';
- c1.updateAriaLabel();
- expect(c1.getAttribute('aria-label'), 'Batman');
-
- Polymer.dom(c1).text = 'Robin';
- c1.updateAriaLabel();
- expect(c1.getAttribute('aria-label'), 'Robin');
- });
});
group('a11y', () {
@@ -102,11 +92,7 @@ main() async {
});
test('checkbox with no label has no aria label', () {
- expect(c1.getAttribute('aria-label'), isEmpty);
- });
-
- test('checkbox with a label sets an aria label', () {
- expect(c2.getAttribute('aria-label'), equals("Batman"));
+ expect(c1.getAttribute('aria-label'), isNull);
});
test('checkbox respects the user set aria-label', () {
« no previous file with comments | « test/paper_button_test.dart ('k') | test/paper_checked_element_behavior_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698