Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: lib/src/google-map/google-map-directions.html

Issue 1418513006: update elements and fix some bugs (Closed) Base URL: git@github.com:dart-lang/polymer_elements.git@master
Patch Set: code review updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/google-map/google-map.html ('k') | lib/src/google-map/google-map-marker.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/google-map/google-map-directions.html
diff --git a/lib/src/google-map/google-map-directions.html b/lib/src/google-map/google-map-directions.html
index c6e7f62645b688e1894edcdf3f99188e4eeb1e58..e5750113415e973ed2ca38eef545a28fee1d90ad 100644
--- a/lib/src/google-map/google-map-directions.html
+++ b/lib/src/google-map/google-map-directions.html
@@ -33,7 +33,6 @@ information on the API.
<template>
<google-maps-api
api-key="[[apiKey]]"
- libraries="[[libraries]]"
language="[[language]]"
on-api-load="_mapApiLoaded"></google-maps-api>
</template>
@@ -48,8 +47,7 @@ information on the API.
Fired whenever the directions service returns a result.
@event google-map-response
-@param {Object} detail
-@param {object} detail.response The directions service response.
+@param {{response: Object}}} detail
*/
properties: {
/**
@@ -110,20 +108,6 @@ Fired whenever the directions service returns a result.
},
/**
- * A comma separated list (e.g. "places,geometry") of libraries to load
- * with this map. Defaults to "places". For more information see
- * https://developers.google.com/maps/documentation/javascript/libraries.
- *
- * Note, this needs to be set to the same value as the one used on <google-map>.
- * If you're overriding that element's `libraries` property, this one also
- * needs to be set to the Maps API loads the library code.
- */
- libraries: {
- type: String,
- value: 'places'
- },
-
- /**
* The localized language to load the Maps API with. For more information
* see https://developers.google.com/maps/documentation/javascript/basics#Language
*
@@ -136,6 +120,14 @@ Fired whenever the directions service returns a result.
},
/**
+ * Options for the display of results
+ */
+ rendererOptions: {
+ type: Object,
+ value: function() { return {}; }
+ },
+
+ /**
* The response from the directions service.
*
*/
@@ -163,7 +155,7 @@ Fired whenever the directions service returns a result.
_mapChanged: function() {
if (this.map && this.map instanceof google.maps.Map) {
if (!this.directionsRenderer) {
- this.directionsRenderer = new google.maps.DirectionsRenderer();
+ this.directionsRenderer = new google.maps.DirectionsRenderer(this.rendererOptions);
}
this.directionsRenderer.setMap(this.map);
this._responseChanged();
« no previous file with comments | « lib/src/google-map/google-map.html ('k') | lib/src/google-map/google-map-marker.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698