Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/firebase-element/test/firebase-collection.html

Issue 1418513006: update elements and fix some bugs (Closed) Base URL: git@github.com:dart-lang/polymer_elements.git@master
Patch Set: code review updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/firebase-element/firebase-query-behavior.html ('k') | lib/src/firebase-element/test/test-helpers.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/firebase-element/test/firebase-collection.html
diff --git a/lib/src/firebase-element/test/firebase-collection.html b/lib/src/firebase-element/test/firebase-collection.html
index 8aecae4105c63486bd1cb79566ecd23a144e31a3..3866864ee636a12bf3a08f6627f98c8a8941446d 100644
--- a/lib/src/firebase-element/test/firebase-collection.html
+++ b/lib/src/firebase-element/test/firebase-collection.html
@@ -17,7 +17,6 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
<script src="../../test-fixture/test-fixture-mocha.js"></script>
<link rel="import" href="../../polymer/polymer.html">
- <link rel="import" href="../../promise-polyfill/promise-polyfill.html">
<link rel="import" href="../../test-fixture/test-fixture.html">
<link rel="import" href="test-helpers.html">
<link rel="import" href="../firebase-collection.html">
@@ -25,42 +24,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
<body>
<test-fixture id="TrivialCollection">
<template>
- <firebase-collection
- location="https://fb-element-demo.firebaseio.com/test/trivial"
- log>
- </firebase-collection>
- </template>
- </test-fixture>
- <test-fixture id="PrimitiveCollection">
- <template>
- <firebase-collection
- location="https://fb-element-demo.firebaseio.com/test/primitives"
- order-by-value
- log>
- </firebase-collection>
- </template>
- </test-fixture>
- <test-fixture id="ChangingChildren">
- <template>
- <firebase-collection
- location="https://fb-element-demo.firebaseio.com/test/changing_children"
- order-by-child="foo"
- log>
- </firebase-collection>
- </template>
- </test-fixture>
-
- <test-fixture id="SyncingCollections">
- <template>
- <firebase-collection
- location="https://fb-element-demo.firebaseio.com/test/syncing"
- log>
- </firebase-collection>
- <firebase-collection
- location="https://fb-element-demo.firebaseio.com/test/syncing"
- order-by-child="foo"
- log>
- </firebase-collection>
+ <firebase-collection log></firebase-collection>
</template>
</test-fixture>
@@ -75,7 +39,6 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
<div>[[item.value]]</div>
</template>
<firebase-collection
- location="https://fb-element-demo.firebaseio.com/test/empty"
data="{{data}}"
log>
</firebase-collection>
@@ -85,217 +48,228 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
</test-fixture>
<script>
- suite('<firebase-collection>', function() {
+
+ suite('firebase-collection', function() {
var firebase;
- suite('collection manipulation', function() {
- var domBind;
- var dom;
+ teardown(function() {
+ if (firebase) {
+ removeFirebase(firebase);
+ }
+ });
+
+ suite('basic usage', function() {
+ var numberOfItems;
setup(function() {
- dom = fixture('BoundCollection');
- domBind = dom.querySelector('[is=dom-bind]');
- firebase = dom.querySelector('firebase-collection');
+ numberOfItems = 3;
+ firebase = fixtureFirebase('TrivialCollection', arrayOfObjects(numberOfItems));
});
- test('added values reflect 1-to-1 in the DOM', function(done) {
- waitForEvent(firebase, 'firebase-value').then(function() {
- waitForEvent(firebase, 'firebase-child-added').then(function() {
- expect(dom.querySelectorAll('div').length).to.be.equal(firebase.data.length);
- done();
- });
- domBind.unshift('data', { value: 'blah' });
- });
+ test('exposes data as an array', function() {
+ expect(firebase.data).to.be.an('array');
+ expect(firebase.data.length).to.be.equal(numberOfItems);
+ });
+
+ test('receives data from Firebase location', function() {
+ expect(firebase.data[0].value).to.be.a('number');
});
});
- suite('basic usage', function() {
+ suite('ordered primitives', function() {
+ var numberOfItems;
+
setup(function() {
- firebase = fixture('TrivialCollection');
+ numberOfItems = 5;
+ firebase = fixtureFirebase('TrivialCollection', arrayOfPrimitives(numberOfItems));
+ firebase.orderByValue = true;
});
- teardown(function() {
- firebase.disconnect();
+ test('converts primitives into objects with a value key', function() {
+ expect(firebase.data[0]).to.be.an('object');
});
- test('exposes data as an array', function(done) {
- waitForEvent(firebase, 'firebase-child-added').then(function() {
- expect(firebase.data).to.be.an('array');
- done();
- }).catch(function(e) {
- done(e);
- });
- });
+ test('orders primitives by value', function() {
+ var lastValue = -Infinity;
- test('receives data from Firebase location', function(done) {
- waitForEvent(firebase, 'data-changed').then(function() {
- expect(firebase.data[0].value).to.be.equal(true);
- done();
- }).catch(function(e) {
- done(e);
+ expect(firebase.data.length).to.be.equal(numberOfItems);
+
+ firebase.data.forEach(function(datum) {
+ expect(datum.value).to.not.be.lessThan(lastValue);
+ lastValue = datum.value;
});
});
});
- suite('ordered primitives', function() {
+ suite('removing a value locally', function() {
+ var numberOfItems;
setup(function() {
- firebase = fixture('PrimitiveCollection');
+ numberOfItems = 3;
+ firebase = fixtureFirebase('TrivialCollection', arrayOfObjects(numberOfItems));
});
- teardown(function() {
- firebase.disconnect();
+ test('works for data-bound changes', function() {
+ firebase.splice('data', 0, 1);
+ expect(firebase.data.length).to.be.equal(numberOfItems - 1);
});
- test('converts primitives into objects with a value key', function(done) {
- waitForEvent(firebase, 'firebase-child-added').then(function() {
- expect(firebase.data[0]).to.be.an('object');
- done();
- }).catch(function(e) {
- done(e);
- });
+ test('can be done with `remove`', function() {
+ var objectToBeRemoved = firebase.data[0];
+ firebase.remove(objectToBeRemoved);
+
+ expect(firebase.data.length).to.be.equal(numberOfItems - 1);
+ expect(firebase.data.indexOf(objectToBeRemoved)).to.be.equal(-1);
});
+ });
- test('orders primitives by value', function(done) {
- waitForEvent(firebase, 'firebase-value').then(function() {
- var lastValue = -Infinity;
- expect(firebase.data.length).to.be.greaterThan(0);
- firebase.data.forEach(function(item) {
- expect(item.value).to.not.be.lessThan(lastValue);
- lastValue = item.value;
- });
+ suite('adding a value locally', function() {
+ setup(function() {
+ firebase = fixtureFirebase('TrivialCollection');
+ });
+
+ test('works for data-bound changes', function(done) {
+ var intendedValue = randomInt();
+ var index = firebase.push('data', intendedValue) - 1;
+
+ // NOTE(cdata): See polymer/polymer#2491.
+ Polymer.Base.async(function() {
+ expect(firebase.data[index]).to.have.property('value');
+ expect(firebase.data[index].value).to.be.equal(intendedValue);
done();
- }).catch(function(e) {
- done(e);
- });
+ }, 1);
});
- suite('adding a value locally', function() {
- setup(function(done) {
- waitForEvent(firebase, 'firebase-value').then(function() {
- done();
- }).catch(function(e) {
- done(e);
- });
- });
+ test('can be done with `add`', function(done) {
+ var object = randomObject();
+ var length = firebase.data.length;
+ var foundObject;
- test('can be done with `add`', function(done) {
- var length = firebase.data.length;
- var newValue = firebase.data[firebase.data.length - 1].value + 1;
- var key;
+ firebase.add(object);
- waitForEvent(firebase, 'firebase-child-added').then(function() {
- expect(firebase.data.length).to.be.equal(length + 1);
- expect(firebase.data[firebase.data.length - 1].value).to.be.equal(newValue);
- done();
- }).catch(function(e) {
- done(e);
- }).then(function() {
- firebase.removeByKey(key);
+ // NOTE(cdata): See polymer/polymer#2491.
+ Polymer.Base.async(function() {
+ expect(firebase.data.length).to.be.equal(length + 1);
+
+ firebase.data.forEach(function(datum) {
+ if (datum.value === object.value) {
+ foundObject = datum;
+ }
});
- key = firebase.add(newValue).key();
- });
+ expect(foundObject).to.be.okay;
+ expect(foundObject.value).to.be.equal(object.value);
+ done();
+ }, 1);
});
});
- suite('a child changes', function() {
- setup(function(done) {
- firebase = fixture('ChangingChildren');
- waitForEvent(firebase, 'firebase-value').then(function() {
- done();
- }).catch(function(e) {
- done(e)
- });
+ suite('a changing child', function() {
+ var numberOfItems;
+ var remoteFirebase;
+
+ setup(function() {
+ numberOfItems = 3;
+ firebase = fixtureFirebase('TrivialCollection', arrayOfObjects(numberOfItems));
+ remoteFirebase = new Firebase(firebase.location);
});
- test('adds a new child based on local changes');
+ test('updates the child key in place with the new value', function() {
+ var datum = firebase.data[0];
+ var newValue = 99999;
+ var key = Polymer.Collection.get(firebase.data).getKey(datum);
- test('updates the child key in place with the new value', function(done) {
- var childrenKeys = [];
+ firebase.set('data.' + key + '.value', newValue);
- waitForEvent(firebase, 'firebase-value').then(function() {
- var middleValue = firebase.getByKey(childrenKeys[1]);
- var changes;
+ expect(firebase.data[0].value).to.be.equal(newValue);
+ });
+ });
- expect(middleValue.foo).to.be.equal(1);
- expect(middleValue.bar).to.be.equal(1);
+ suite('syncing collections', function() {
+ var numberOfItems;
+ var remoteFirebase;
- changes = waitForEvent(firebase, 'firebase-child-changed');
+ setup(function() {
+ numberOfItems = 3;
- firebase.set('data.' + firebase.data.indexOf(middleValue) + '.bar', 2);
+ firebase = fixtureFirebase('TrivialCollection', arrayOfObjects(3));
+ firebase.orderValueType = 'number';
+ firebase.orderByValue = true;
- return changes;
- }).then(function() {
- var middleValue = firebase.getByKey(childrenKeys[1]);
+ remoteFirebase = new Firebase(firebase.location);
+ });
- expect(middleValue.foo).to.be.equal(1);
- expect(middleValue.bar).to.be.equal(2);
+ test('sync a new item at the correct index', function() {
+ var firstValue = firebase.data[0];
+ var secondValue = firebase.data[1];
+ var datum = firebase.data[0];
+ var key = Polymer.Collection.get(firebase.data).getKey(datum);
+ var remoteValue;
- done();
- }).catch(function(e) {
- done(e);
- }).then(function() {
- childrenKeys.forEach(function(key) {
- firebase.removeByKey(key);
- });
+ remoteFirebase.on('value', function(snapshot) {
+ remoteValue = snapshot.val();
});
- childrenKeys = [0, 1, 2].map(function(value, index) {
- return firebase.add({
- foo: value,
- bar: index
- }).key();
- });
+ expect(remoteValue[0].value).to.be.equal(firebase.data[0].value);
});
});
- suite('syncing collections', function() {
- var localFirebase;
- var remoteFirebase;
+ suite('data-bound collection manipulation', function() {
+ var numberOfItems;
+ var elements;
+ var domBind;
- setup(function(done) {
- firebase = fixture('SyncingCollections');
- localFirebase = firebase[0];
- remoteFirebase = firebase[1];
- Promise.all([
- waitForEvent(localFirebase, 'firebase-value'),
- waitForEvent(remoteFirebase, 'firebase-value')
- ]).then(function() {
- done();
- }).catch(function(e) {
- done(e);
- });
+ setup(function() {
+ elements = fixture('BoundCollection');
+ domBind = elements.querySelector('[is=dom-bind]');
+ firebase = elements.querySelector('firebase-collection');
+ firebase.location = fixtureLocation(arrayOfObjects(3));
+ numberOfItems = 3;
});
- test('syncs a new item at the correct index', function(done) {
- var data = {
- foo: 100
- };
- var key;
+ test('splices reflect in Firebase data', function(done) {
+ domBind.splice('data', 0, 1, randomObject());
+ domBind.shift('data');
+ domBind.push.apply(domBind, ['data'].concat(arrayOfObjects(2)));
- waitForEvent(remoteFirebase, 'firebase-value').then(function() {
- var value = remoteFirebase.getByKey(key);
- var lowValue = remoteFirebase.getByKey('lowValue');
- var highValue = remoteFirebase.getByKey('highValue');
+ // NOTE(cdata): See polymer/polymer#2491.
+ Polymer.Base.async(function() {
+ expect(firebase.data.length).to.be.equal(domBind.data.length);
- var index = remoteFirebase.data.indexOf(value);
- var lowIndex = remoteFirebase.data.indexOf(lowValue);
- var highIndex = remoteFirebase.data.indexOf(highValue);
+ firebase.data.forEach(function(datum, index) {
+ expect(domBind.data[index].value).to.be.equal(datum.value);
+ });
- expect(value).to.be.okay;
- expect(index).to.be.lessThan(highIndex);
- expect(index).to.be.greaterThan(lowIndex);
done();
- }).catch(function(e) {
- done(e);
- }).then(function() {
- localFirebase.removeByKey(key);
- });
+ }, 1);
+ });
+
+ test('splices reflect in the DOM', function(done) {
+ var divs;
+
+ firebase.push.apply(firebase, ['data'].concat(arrayOfObjects(3)));
+
+ Polymer.Base.async(function() {
+ divs = elements.querySelectorAll('div');
+ expect(divs.length).to.be.equal(firebase.data.length);
+
+ domBind.splice('data', 2, 1, randomObject());
- key = localFirebase.add(data).key();
+ Polymer.Base.async(function() {
+ divs = elements.querySelectorAll('div');
+ expect(divs.length).to.be.equal(firebase.data.length);
+
+ firebase.data.forEach(function(datum, index) {
+ var divValue = parseInt(divs[index].textContent, 10);
+ expect(datum.value).to.be.equal(divValue);
+ });
+
+ done();
+ }, 1);
+ }, 1);
});
});
});
+
</script>
</body>
« no previous file with comments | « lib/src/firebase-element/firebase-query-behavior.html ('k') | lib/src/firebase-element/test/test-helpers.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698