lib/iron_overlay_behavior.dart - Issue 1418513006: update elements and fix some bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/iron_overlay_behavior.dart

Issue 1418513006: update elements and fix some bugs (Closed) Base URL: git@github.com:dart-lang/polymer_elements.git@master

Patch Set: code review updates Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/iron_overlay_behavior.dart

diff --git a/lib/iron_overlay_behavior.dart b/lib/iron_overlay_behavior.dart

index eee295c57f909103df2293f4fa6e2869eaf9182c..1621810ccba5dfcb790cf2f5aa3eca7934155f53 100644

--- a/lib/iron_overlay_behavior.dart

+++ b/lib/iron_overlay_behavior.dart

@@ -23,7 +23,8 @@ import 'iron_overlay_backdrop.dart';

/// it will cancel whenever the user taps outside it or presses the escape key. This behavior is

/// configurable with the `no-cancel-on-esc-key` and the `no-cancel-on-outside-click` properties.

/// `close()` should be called explicitly by the implementer when the user interacts with a control

-/// in the overlay element.

+/// in the overlay element. When the dialog is canceled, the overlay fires an 'iron-overlay-canceled'

+/// event. Call `preventDefault` on this event to prevent the overlay from closing.

///

/// ### Positioning

///

« no previous file with comments | « lib/iron_media_query.dart ('k') | lib/iron_range_behavior.dart » ('j') | no next file with comments »