Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: ui/ozone/platform/drm/gpu/crtc_controller.h

Issue 1418503012: [Ozone-DRM] Remove bool return value for SchedulePageFlip call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased & updated Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/ozone/platform/drm/gpu/crtc_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ozone/platform/drm/gpu/crtc_controller.h
diff --git a/ui/ozone/platform/drm/gpu/crtc_controller.h b/ui/ozone/platform/drm/gpu/crtc_controller.h
index 6d05ce60aa2f6a2e4a659e09f0025cb8c419e33e..676f052a2168151ff1d22f3c7a3546f04d4be05b 100644
--- a/ui/ozone/platform/drm/gpu/crtc_controller.h
+++ b/ui/ozone/platform/drm/gpu/crtc_controller.h
@@ -11,6 +11,7 @@
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
+#include "ui/gfx/swap_result.h"
#include "ui/ozone/ozone_export.h"
#include "ui/ozone/platform/drm/common/scoped_drm_types.h"
#include "ui/ozone/platform/drm/gpu/hardware_display_plane_manager.h"
@@ -58,8 +59,10 @@ class OZONE_EXPORT CrtcController
std::vector<uint32_t> GetCompatibleHardwarePlaneIds(
const OverlayPlane& plane) const;
- // Called if the page flip for this CRTC fails after being scheduled.
- void PageFlipFailed();
+ // Called if the page flip event wasn't scheduled (ie: page flip fails). This
+ // will then signal the request such that the caller doesn't wait for the
+ // event forever.
+ void SignalPageFlipRequest(gfx::SwapResult result);
// Called when the page flip event occurred. The event is provided by the
// kernel when a VBlank event finished. This allows the controller to
@@ -77,8 +80,6 @@ class OZONE_EXPORT CrtcController
private:
bool ResetCursor();
- void SignalPageFlipRequest();
-
scoped_refptr<DrmDevice> drm_;
// Buffers need to be declared first so that they are destroyed last. Needed
« no previous file with comments | « no previous file | ui/ozone/platform/drm/gpu/crtc_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698