Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc

Issue 1418503012: [Ozone-DRM] Remove bool return value for SchedulePageFlip call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc
diff --git a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc
index 6cb003078c4b6280cb799c0872fc575111266c5e..c90abe87cd7b6ada102a90281dd9c01174864698 100644
--- a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc
+++ b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc
@@ -46,7 +46,7 @@ bool HardwareDisplayPlaneManagerLegacy::Commit(
PLOG(ERROR) << "Cannot display plane on overlay: crtc=" << flip.crtc
<< " plane=" << plane.plane;
ret = false;
- flip.crtc->PageFlipFailed();
+ flip.crtc->SignalPageFlipRequest(gfx::SwapResult::SWAP_FAILED);
break;
}
}
@@ -66,7 +66,8 @@ bool HardwareDisplayPlaneManagerLegacy::Commit(
<< " framebuffer=" << flip.framebuffer;
ret = false;
}
- flip.crtc->PageFlipFailed();
+ flip.crtc->SignalPageFlipRequest(ret ? gfx::SwapResult::SWAP_ACK
+ : gfx::SwapResult::SWAP_FAILED);
}
}
// For each element in |old_plane_list|, if it hasn't been reclaimed (by

Powered by Google App Engine
This is Rietveld 408576698