Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1418503009: dart2js: Bugfix in async rewriter preanalysis. (Closed)

Created:
5 years, 1 month ago by asgerf
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Bugfix in async rewriter preanalysis. Name and StringConcatenation nodes would be classified as await/yield, causing their surrounding expressions to be exploded into temporaries. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/b123d5393fb476adb5d11b111d07cd8dc925a7ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
For example: list.push(resultA + resultB) would previously translate to: $async$temp1 = list; $async$temp1 = $async$temp1; ...
5 years, 1 month ago (2015-10-29 11:05:37 UTC) #2
sigurdm
Good catch! Thank you LGTM
5 years, 1 month ago (2015-10-29 11:44:21 UTC) #3
asgerf
5 years, 1 month ago (2015-10-29 12:43:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b123d5393fb476adb5d11b111d07cd8dc925a7ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698