src/processor/stackwalk_common.cc - Issue 1418453011: [mips64] Support for mips n64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/processor/stackwalk_common.cc

Issue 1418453011: [mips64] Support for mips n64 (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: addressing comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/processor/stackwalk_common.cc

diff --git a/src/processor/stackwalk_common.cc b/src/processor/stackwalk_common.cc

index 3a6e17feca87c5514272b8563e91b6edbe317204..b864f55350ba197db2ced7632a5a1fbeda6df9ad 100644

--- a/src/processor/stackwalk_common.cc

+++ b/src/processor/stackwalk_common.cc

@@ -546,7 +546,7 @@ static void PrintStack(const CallStack *stack,

sequence =

PrintRegister64("pc", frame_arm64->context.iregs[32], sequence);

}

- } else if (cpu == "mips") {

+ } else if ((cpu == "mips") || (cpu == "mips64")) {

const StackFrameMIPS* frame_mips =

reinterpret_cast<const StackFrameMIPS*>(frame);