Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: src/tools/linux/md2core/minidump-2-core.cc

Issue 1418453011: [mips64] Support for mips n64 (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/tools/linux/md2core/minidump-2-core.cc
diff --git a/src/tools/linux/md2core/minidump-2-core.cc b/src/tools/linux/md2core/minidump-2-core.cc
index 8e9cd1291a0d14e6b54178c05065dfbc66690329..cb0ac30a8bcdc1e2f9c0f1dd6a8f4e4c22e9ece9 100644
--- a/src/tools/linux/md2core/minidump-2-core.cc
+++ b/src/tools/linux/md2core/minidump-2-core.cc
@@ -493,12 +493,18 @@ ParseSystemInfo(CrashedProcess* crashinfo, const MinidumpMemoryRange& range,
"This version of minidump-2-core only supports ARM (64bit).\n");
_exit(1);
}
-#elif defined(__mips__)
+#elif defined(__mips__) && _MIPS_SIM == _ABIO32
if (sysinfo->processor_architecture != MD_CPU_ARCHITECTURE_MIPS) {
fprintf(stderr,
"This version of minidump-2-core only supports mips (32bit).\n");
vapier 2015/12/15 17:29:27 would be nice imo to put "o32" in here
mveljko 2015/12/17 13:36:24 Done.
_exit(1);
}
+#elif defined(__mips__) && _MIPS_SIM == _ABI64
+ if (sysinfo->processor_architecture != MD_CPU_ARCHITECTURE_MIPS64) {
+ fprintf(stderr,
+ "This version of minidump-2-core only supports mips (64bit).\n");
vapier 2015/12/15 17:29:27 would be nice imo to put "o64" in here
mveljko 2015/12/17 13:36:24 Done.
+ _exit(1);
+ }
#else
#error "This code has not been ported to your platform yet"
#endif
@@ -525,6 +531,8 @@ ParseSystemInfo(CrashedProcess* crashinfo, const MinidumpMemoryRange& range,
? "ARM"
: sysinfo->processor_architecture == MD_CPU_ARCHITECTURE_MIPS
? "MIPS"
+ : sysinfo->processor_architecture == MD_CPU_ARCHITECTURE_MIPS64
+ ? "MIPS64"
: "???",
sysinfo->number_of_processors,
sysinfo->processor_level,

Powered by Google App Engine
This is Rietveld 408576698