src/full-codegen/full-codegen.cc - Issue 1418433002: Always give class literals a block scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1418433002: Always give class literals a block scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix vector stores Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 35c074db38ef90d47dd2106a960c37612ac4215a..e6581b994fd2bdb71107d9d0e9c9907539959c20 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -1330,8 +1330,7 @@ void FullCodeGenerator::VisitClassLiteral(ClassLiteral* lit) {

EmitClassDefineProperties(lit);

- if (lit->scope() != NULL) {

- DCHECK_NOT_NULL(lit->class_variable_proxy());

+ if (lit->class_variable_proxy() != nullptr) {

EmitVariableAssignment(lit->class_variable_proxy()->var(),

Token::INIT_CONST, lit->ProxySlot());

}

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/parser.cc » ('j') | no next file with comments »