src/ast.h - Issue 1418433002: Always give class literals a block scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.h

Issue 1418433002: Always give class literals a block scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix vector stores Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.h

diff --git a/src/ast.h b/src/ast.h

index 0c6d2138fd97aa143cd3eac94b81a5226b537b9a..f1adf528a20ea5a6c9d61408f4ef289a2765b11d 100644

--- a/src/ast.h

+++ b/src/ast.h

@@ -2662,7 +2662,7 @@ class ClassLiteral final : public Expression {

FeedbackVectorSlotCache* cache) override;

bool NeedsProxySlot() const {

- return FLAG_vector_stores && scope() != NULL &&

+ return FLAG_vector_stores && class_variable_proxy() != nullptr &&

class_variable_proxy()->var()->IsUnallocated();

}

« no previous file with comments | « no previous file | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »