Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: src/ast.h

Issue 1418433002: Always give class literals a block scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix vector stores Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_AST_H_ 5 #ifndef V8_AST_H_
6 #define V8_AST_H_ 6 #define V8_AST_H_
7 7
8 #include "src/assembler.h" 8 #include "src/assembler.h"
9 #include "src/ast-value-factory.h" 9 #include "src/ast-value-factory.h"
10 #include "src/bailout-reason.h" 10 #include "src/bailout-reason.h"
(...skipping 2644 matching lines...) Expand 10 before | Expand all | Expand 10 after
2655 // Unlike other AST nodes, this number of bailout IDs allocated for an 2655 // Unlike other AST nodes, this number of bailout IDs allocated for an
2656 // ClassLiteral can vary, so num_ids() is not a static method. 2656 // ClassLiteral can vary, so num_ids() is not a static method.
2657 int num_ids() const { return parent_num_ids() + 4 + properties()->length(); } 2657 int num_ids() const { return parent_num_ids() + 4 + properties()->length(); }
2658 2658
2659 // Object literals need one feedback slot for each non-trivial value, as well 2659 // Object literals need one feedback slot for each non-trivial value, as well
2660 // as some slots for home objects. 2660 // as some slots for home objects.
2661 void AssignFeedbackVectorSlots(Isolate* isolate, FeedbackVectorSpec* spec, 2661 void AssignFeedbackVectorSlots(Isolate* isolate, FeedbackVectorSpec* spec,
2662 FeedbackVectorSlotCache* cache) override; 2662 FeedbackVectorSlotCache* cache) override;
2663 2663
2664 bool NeedsProxySlot() const { 2664 bool NeedsProxySlot() const {
2665 return FLAG_vector_stores && scope() != NULL && 2665 return FLAG_vector_stores && class_variable_proxy() != nullptr &&
2666 class_variable_proxy()->var()->IsUnallocated(); 2666 class_variable_proxy()->var()->IsUnallocated();
2667 } 2667 }
2668 2668
2669 FeedbackVectorSlot ProxySlot() const { return slot_; } 2669 FeedbackVectorSlot ProxySlot() const { return slot_; }
2670 2670
2671 protected: 2671 protected:
2672 ClassLiteral(Zone* zone, const AstRawString* name, Scope* scope, 2672 ClassLiteral(Zone* zone, const AstRawString* name, Scope* scope,
2673 VariableProxy* class_variable_proxy, Expression* extends, 2673 VariableProxy* class_variable_proxy, Expression* extends,
2674 FunctionLiteral* constructor, ZoneList<Property*>* properties, 2674 FunctionLiteral* constructor, ZoneList<Property*>* properties,
2675 int start_position, int end_position) 2675 int start_position, int end_position)
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
3633 // the parser-level zone. 3633 // the parser-level zone.
3634 Zone* parser_zone_; 3634 Zone* parser_zone_;
3635 AstValueFactory* ast_value_factory_; 3635 AstValueFactory* ast_value_factory_;
3636 }; 3636 };
3637 3637
3638 3638
3639 } // namespace internal 3639 } // namespace internal
3640 } // namespace v8 3640 } // namespace v8
3641 3641
3642 #endif // V8_AST_H_ 3642 #endif // V8_AST_H_
OLDNEW
« no previous file with comments | « no previous file | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698