Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1418433002: Always give class literals a block scope (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, mvstanton
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always give class literals a block scope Re-land of https://crrev.com/cf13dda1ba25e8293ea143f33c6c5f6233a39c86, fixing the issue with vector stores. Class methods always have the class scope on their scope chain in order to implement strong mode checks. Previously, that scope wasn't attached to the ClassLiteral for anonymous classes (since the scope contained no bindings). This patch simply puts that same scope on the ClassLiteral, anonymous or not, which simplifies other code that needs to reason about the scope of a class and its methods. Committed: https://crrev.com/b065411f81e1fff769de691d8494d6f75c7132a9 Cr-Commit-Position: refs/heads/master@{#31381}

Patch Set 1 #

Patch Set 2 : Fix vector stores #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M src/ast.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
5 years, 2 months ago (2015-10-19 13:32:05 UTC) #2
Michael Starzinger
LGTM on patch set #2.
5 years, 2 months ago (2015-10-19 15:11:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418433002/20001
5 years, 2 months ago (2015-10-19 15:14:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-19 15:16:06 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 15:16:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b065411f81e1fff769de691d8494d6f75c7132a9
Cr-Commit-Position: refs/heads/master@{#31381}

Powered by Google App Engine
This is Rietveld 408576698