rAc: fix some validation issues

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 1727 matching lines @@
   return value.empty() ?
       l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_VALIDATION_MISSING_VALUE) :
       base::string16();
 }
 
 // TODO(groby): Also add tests.
 ValidityMessages AutofillDialogControllerImpl::InputsAreValid(
     DialogSection section,
     const FieldValueMap& inputs) {
   ValidityMessages messages;
-  FieldValueMap field_values;
   for (FieldValueMap::const_iterator iter = inputs.begin();
        iter != inputs.end(); ++iter) {
     const ServerFieldType type = iter->first;
 
     base::string16 text = InputValidityMessage(section, type, iter->second);
 
     // Skip empty/unchanged fields in edit mode. Ignore country as it always has
     // a value. If the individual field does not have validation errors, assume
     // it to be valid unless later proven otherwise.
     bool sure = InputWasEdited(type, iter->second) ||
                 AutofillType(type).GetStorableType() == ADDRESS_HOME_COUNTRY;
-
-    // Consider only individually valid fields for inter-field validation.
-    if (text.empty()) {
-      field_values[type] = iter->second;
-      // If the field is valid but can be invalidated by inter-field validation,

[Evan Stade, 2014/01/31 00:22:13]

example of the problem this caused:

1) CC is invalid (but type can be determined as Visa)
2) CVC is invalid (4 digits)
thus) CC is not in field_values, so CVC doesn't get cross-validated. Since it is
non-empty, it's marked as valid.

[groby-ooo-7-16, 2014/01/31 19:59:59]

I'm not sure this addresses that issue without side effects. For one, this will
now treat the month as invalid if no year is picked yet. I'm also not sure what
sure = false does in the phone number case.

Do we want inter-field validation to _always_ occur? In which case, yay for
deleting code.

[Evan Stade, 2014/01/31 21:50:28]

yes, we want it to always occur, so that we can validate field X based on the
value of field Y even if field Y is already known to be invalid. In the
expiration date case, the InputWasEdited checks prevent what you describe from
happening.

-      // assume it to be unsure.
-      if (type == CREDIT_CARD_EXP_4_DIGIT_YEAR ||
-          type == CREDIT_CARD_EXP_MONTH ||
-          type == CREDIT_CARD_VERIFICATION_CODE ||
-          type == PHONE_HOME_WHOLE_NUMBER ||
-          type == PHONE_BILLING_WHOLE_NUMBER) {
-        sure = false;
-      }
-    }
     messages.Set(type, ValidityMessage(text, sure));
   }
 
+  // For the convenience of using operator[].
+  FieldValueMap& field_values = const_cast<FieldValueMap&>(inputs);
   // Validate the date formed by month and year field. (Autofill dialog is
   // never supposed to have 2-digit years, so not checked).
   if (field_values.count(CREDIT_CARD_EXP_4_DIGIT_YEAR) &&
       field_values.count(CREDIT_CARD_EXP_MONTH) &&
       InputWasEdited(CREDIT_CARD_EXP_4_DIGIT_YEAR,
                      field_values[CREDIT_CARD_EXP_4_DIGIT_YEAR]) &&
       InputWasEdited(CREDIT_CARD_EXP_MONTH,
                      field_values[CREDIT_CARD_EXP_MONTH])) {
     ValidityMessage year_message(base::string16(), true);
     ValidityMessage month_message(base::string16(), true);
@@ skipping 1861 matching lines @@
   view_->UpdateButtonStrip();
 }
 
 void AutofillDialogControllerImpl::FetchWalletCookie() {
   net::URLRequestContextGetter* request_context = profile_->GetRequestContext();
   signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context));
   signin_helper_->StartWalletCookieValueFetch();
 }
 
 }  // namespace autofill