Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 141833002: Revert 245445 "Unifies LayerTreeHost::SetNeedsUpdateLayers and S..." (Closed)

Created:
6 years, 11 months ago by Mark Mentovai
Modified:
6 years, 11 months ago
Reviewers:
trchen
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 245445 "Unifies LayerTreeHost::SetNeedsUpdateLayers and S..." Speculative. This may have caused flakiness on multiple bots. See bug 335582. > Unifies LayerTreeHost::SetNeedsUpdateLayers and SetNeedsAnimate -- V2 > > [2/2] Unifies LayerTreeHost::SetNeedsUpdateLayers and SetNeedsAnimate > > They basically do the same thing except that SetNeedsAnimate makes the next > commit non-cancellable. However there is really no reason why SetNeedsAnimate > need to enforce a commit even if no tiles are updated and no layer properties > changed. > > SetNeedsAnimate is thus merged into SetNeedsUpdateLayers. The proper use of > it is when there are potential layout/tile changes, we can use it to defer > calculation until the next frame. A commit will be scheduled but can be > cancelled if no updates are needed after calculation. > > This part of the patch changes code behavior slightly. > SingleThreadProxy::SetNeedsUpdateLayers was originally implemented as > RenderWidget::ScheduleComposite but now it is RenderWidget::ScheduleAnimation. > ThreadProxy::SetNeedsAnimate was non-cancellable but is now cancellable. > > [1/2] Cleanup RenderWidget::scheduleComposite/scheduleAnimation > > scheduleComposite has been renamed to ScheduleComposite as it is no longer > a part of WebWidgetClient API. > > scheduleAnimation has been renamed to ScheduleAnimation. The semantics is to > schedule a composite and also (potentially) animating WebWidget. > > A new WebWidgetClient API scheduleUpdate has been added, to replace the old > scheduleAnimation. The semantics is to notify the embedder that something in > the WebWidget may change in 0 seconds. (i.e. it is allowed to be called > during a redraw, in such case another redraw will be scheduled after frame > delay. > > This part of the patch should not change code behavior. > > BUG=316929 > R=danakj,jamesr,jochen > > Review URL: https://codereview.chromium.org/133263004 TBR=trchen@chromium.org BUG=335582 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -149 lines) Patch
M trunk/src/cc/test/fake_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/cc/test/layer_tree_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/test/layer_tree_test.cc View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest_animation.cc View 8 chunks +17 lines, -26 lines 0 comments Download
M trunk/src/cc/trees/proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.cc View 1 chunk +6 lines, -1 line 0 comments Download
M trunk/src/cc/trees/thread_proxy.h View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.cc View 6 chunks +27 lines, -19 lines 0 comments Download
M trunk/src/content/renderer/gpu/render_widget_compositor.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/gpu/render_widget_compositor.cc View 3 chunks +6 lines, -16 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/render_widget.h View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/render_widget.cc View 6 chunks +29 lines, -40 lines 0 comments Download
M trunk/src/content/shell/renderer/test_runner/WebTestProxy.h View 5 chunks +12 lines, -12 lines 0 comments Download
M trunk/src/content/shell/renderer/test_runner/WebTestProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M trunk/src/mojo/examples/compositor_app/compositor_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
6 years, 11 months ago (2014-01-17 16:35:12 UTC) #1
Mark Mentovai
6 years, 11 months ago (2014-01-17 16:35:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245528 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698