Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1418303002: Revert of OrdinaryDefineOwnProperty: always reset the LookupIterator before storing. (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of OrdinaryDefineOwnProperty: always reset the LookupIterator before storing. (patchset #1 id:1 of https://codereview.chromium.org/1415823003/ ) Reason for revert: Breaks test if rolled into Chromium: http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%281%29&number=60441 Original issue's description: > OrdinaryDefineOwnProperty: always reset the LookupIterator before storing. > > Committed: https://crrev.com/7bc5ce16ee9244869384cdf17ea2feb0a9dde9bd > Cr-Commit-Position: refs/heads/master@{#31511} TBR=cbruni@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/dc9d2c16cd486b38948102df840829674f1e799a Cr-Commit-Position: refs/heads/master@{#31533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/objects.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of OrdinaryDefineOwnProperty: always reset the LookupIterator before storing.
5 years, 2 months ago (2015-10-23 19:20:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418303002/1
5 years, 2 months ago (2015-10-23 19:20:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 19:20:54 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 19:21:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc9d2c16cd486b38948102df840829674f1e799a
Cr-Commit-Position: refs/heads/master@{#31533}

Powered by Google App Engine
This is Rietveld 408576698