Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1418293006: Remove redundant activation threshold for incremental marking. (Closed)

Created:
5 years, 1 month ago by ulan
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove redundant activation threshold for incremental marking. The minimum allocation limit already enforces this constraint for normal GCs. GCs triggered by the memory reducer and external limit should work for all heap sizes. BUG=chromium:552305 LOG=NO Committed: https://crrev.com/e28e4d5f52852e2f14facc37a02069b6bfc82c4e Cr-Commit-Position: refs/heads/master@{#31921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 1 month ago (2015-11-10 15:23:44 UTC) #2
Hannes Payer (out of office)
On 2015/11/10 15:23:44, ulan wrote: > PTAL Lgtm, but watch out for benchmarks.
5 years, 1 month ago (2015-11-10 16:41:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418293006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418293006/1
5 years, 1 month ago (2015-11-10 16:55:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 17:14:10 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e28e4d5f52852e2f14facc37a02069b6bfc82c4e Cr-Commit-Position: refs/heads/master@{#31921}
5 years, 1 month ago (2015-11-10 17:14:26 UTC) #7
ulan
5 years, 1 month ago (2015-11-17 13:12:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1456523002/ by ulan@chromium.org.

The reason for reverting is: Regression in thread_times.key_idle_power_cases
(crbug.com/555153).

Powered by Google App Engine
This is Rietveld 408576698