Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: cc/scheduler/scheduler_unittest.cc

Issue 1418273002: cc: Move draw params from SetExternalDrawConstraints to OnDraw (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests fixed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler_unittest.cc
diff --git a/cc/scheduler/scheduler_unittest.cc b/cc/scheduler/scheduler_unittest.cc
index 0846e954c2a11fef81cc2d4561f12877a4004f96..b31d40829e8a5bb3d3ad320671bc0c56fedd4bfd 100644
--- a/cc/scheduler/scheduler_unittest.cc
+++ b/cc/scheduler/scheduler_unittest.cc
@@ -328,7 +328,8 @@ class SchedulerTest : public testing::Test {
if (scheduler_settings_.using_synchronous_renderer_compositor) {
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ bool resourceless_software_draw = false;
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
} else {
// Run the posted deadline task.
EXPECT_TRUE(scheduler_->BeginImplFrameDeadlinePending());
@@ -3110,7 +3111,8 @@ TEST_F(SchedulerTest, SynchronousCompositorAnimation) {
// Android onDraw. This doesn't consume the animate tick.
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ bool resourceless_software_draw = false;
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
EXPECT_SINGLE_ACTION("ScheduledActionDrawAndSwapIfPossible", client_);
EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
client_->Reset();
@@ -3129,7 +3131,7 @@ TEST_F(SchedulerTest, SynchronousCompositorAnimation) {
// Android onDraw.
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
EXPECT_SINGLE_ACTION("ScheduledActionDrawAndSwapIfPossible", client_);
EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
client_->Reset();
@@ -3149,7 +3151,8 @@ TEST_F(SchedulerTest, SynchronousCompositorOnDrawDuringIdle) {
SetUpScheduler(true);
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ bool resourceless_software_draw = false;
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
EXPECT_ACTION("SetNeedsBeginFrames(true)", client_, 0, 3);
EXPECT_ACTION("ScheduledActionAnimate", client_, 1, 3);
EXPECT_ACTION("ScheduledActionDrawAndSwapIfPossible", client_, 2, 3);
@@ -3208,7 +3211,8 @@ TEST_F(SchedulerTest, SynchronousCompositorCommit) {
// Android onDraw.
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ bool resourceless_software_draw = false;
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
EXPECT_SINGLE_ACTION("ScheduledActionDrawAndSwapIfPossible", client_);
EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
client_->Reset();
@@ -3301,7 +3305,8 @@ TEST_F(SchedulerTest, SynchronousCompositorPrepareTilesOnDraw) {
// Android onDraw.
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ bool resourceless_software_draw = false;
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
EXPECT_ACTION("ScheduledActionDrawAndSwapIfPossible", client_, 0, 2);
EXPECT_ACTION("ScheduledActionPrepareTiles", client_, 1, 2);
EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
@@ -3310,7 +3315,7 @@ TEST_F(SchedulerTest, SynchronousCompositorPrepareTilesOnDraw) {
// Android onDraw.
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
EXPECT_ACTION("ScheduledActionDrawAndSwapIfPossible", client_, 0, 2);
EXPECT_ACTION("ScheduledActionPrepareTiles", client_, 1, 2);
EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
@@ -3346,7 +3351,8 @@ TEST_F(SchedulerTest, SynchronousCompositorSendBeginMainFrameWhileIdle) {
// Android onDraw.
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ bool resourceless_software_draw = false;
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
EXPECT_SINGLE_ACTION("ScheduledActionDrawAndSwapIfPossible", client_);
EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
EXPECT_FALSE(scheduler_->PrepareTilesPending());
@@ -3375,7 +3381,7 @@ TEST_F(SchedulerTest, SynchronousCompositorSendBeginMainFrameWhileIdle) {
// Android onDraw.
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
EXPECT_SINGLE_ACTION("ScheduledActionDrawAndSwapIfPossible", client_);
EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
EXPECT_FALSE(scheduler_->PrepareTilesPending());
@@ -3393,10 +3399,10 @@ TEST_F(SchedulerTest, SynchronousCompositorResourcelessOnDrawWhenInvisible) {
SetUpScheduler(true);
scheduler_->SetVisible(false);
- scheduler_->SetResourcelessSoftareDraw(true);
scheduler_->SetNeedsRedraw();
- scheduler_->OnDrawForOutputSurface();
+ bool resourceless_software_draw = true;
+ scheduler_->OnDrawForOutputSurface(resourceless_software_draw);
// Action animate is the result of SetNeedsRedraw.
EXPECT_ACTION("ScheduledActionAnimate", client_, 0, 2);
// SynchronousCompositor has to draw regardless of visibility.

Powered by Google App Engine
This is Rietveld 408576698