Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: media/capture/video/video_capture_device_unittest.cc

Issue 1418263006: Extend VideoCaptureDevice::Client::OnError() to have a tracked_objects::Location param. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/video_capture_device_unittest.cc
diff --git a/media/capture/video/video_capture_device_unittest.cc b/media/capture/video/video_capture_device_unittest.cc
index b5d1dfcdcd9263a160a26e808973a7f21f215cc3..8271c50bf980905b5771116bc76b03f761348e90 100644
--- a/media/capture/video/video_capture_device_unittest.cc
+++ b/media/capture/video/video_capture_device_unittest.cc
@@ -79,7 +79,9 @@ class MockClient : public VideoCaptureDevice::Client {
MOCK_METHOD0(DoReserveOutputBuffer, void(void));
MOCK_METHOD0(DoOnIncomingCapturedBuffer, void(void));
MOCK_METHOD0(DoOnIncomingCapturedVideoFrame, void(void));
- MOCK_METHOD1(OnError, void(const std::string& reason));
+ MOCK_METHOD2(OnError,
+ void(const tracked_objects::Location& from_here,
+ const std::string& reason));
MOCK_CONST_METHOD0(GetBufferPoolUtilization, double(void));
explicit MockClient(base::Callback<void(const VideoCaptureFormat&)> frame_cb)
@@ -281,7 +283,7 @@ TEST_F(VideoCaptureDeviceTest, MAYBE_OpenInvalidDevice) {
} else {
// The presence of the actual device is only checked on AllocateAndStart()
// and not on creation for QTKit API in Mac OS X platform.
- EXPECT_CALL(*client_, OnError(_)).Times(1);
+ EXPECT_CALL(*client_, OnError(_, _)).Times(1);
VideoCaptureParams capture_params;
capture_params.requested_format.frame_size.SetSize(640, 480);
@@ -311,7 +313,7 @@ TEST_P(VideoCaptureDeviceTest, CaptureWithSize) {
ASSERT_TRUE(device);
DVLOG(1) << names_->front().id();
- EXPECT_CALL(*client_, OnError(_)).Times(0);
+ EXPECT_CALL(*client_, OnError(_, _)).Times(0);
VideoCaptureParams capture_params;
capture_params.requested_format.frame_size.SetSize(width, height);
@@ -344,7 +346,7 @@ TEST_F(VideoCaptureDeviceTest, MAYBE_AllocateBadSize) {
video_capture_device_factory_->Create(names_->front()));
ASSERT_TRUE(device);
- EXPECT_CALL(*client_, OnError(_)).Times(0);
+ EXPECT_CALL(*client_, OnError(_, _)).Times(0);
const gfx::Size input_size(640, 480);
VideoCaptureParams capture_params;
@@ -422,7 +424,7 @@ TEST_F(VideoCaptureDeviceTest, DeAllocateCameraWhileRunning) {
video_capture_device_factory_->Create(names_->front()));
ASSERT_TRUE(device);
- EXPECT_CALL(*client_, OnError(_)).Times(0);
+ EXPECT_CALL(*client_, OnError(_, _)).Times(0);
VideoCaptureParams capture_params;
capture_params.requested_format.frame_size.SetSize(640, 480);
@@ -449,7 +451,7 @@ TEST_F(VideoCaptureDeviceTest, MAYBE_CaptureMjpeg) {
video_capture_device_factory_->Create(*name));
ASSERT_TRUE(device);
- EXPECT_CALL(*client_, OnError(_)).Times(0);
+ EXPECT_CALL(*client_, OnError(_, _)).Times(0);
VideoCaptureParams capture_params;
capture_params.requested_format.frame_size.SetSize(1280, 720);

Powered by Google App Engine
This is Rietveld 408576698