media/capture/content/thread_safe_capture_oracle.h - Issue 1418263006: Extend VideoCaptureDevice::Client::OnError() to have a tracked_objects::Location param.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/content/thread_safe_capture_oracle.h

Issue 1418263006: Extend VideoCaptureDevice::Client::OnError() to have a tracked_objects::Location param. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/capture/content/screen_capture_device_core.cc ('K') | « media/capture/content/screen_capture_device_core.cc ('k') | media/capture/content/thread_safe_capture_oracle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/capture/content/thread_safe_capture_oracle.h

diff --git a/media/capture/content/thread_safe_capture_oracle.h b/media/capture/content/thread_safe_capture_oracle.h

index 1aa905e37f1171a12debfb247c322589eed9e0f4..a410000bcf456a47dcb3597e6a021a2cd0c712fe 100644

--- a/media/capture/content/thread_safe_capture_oracle.h

+++ b/media/capture/content/thread_safe_capture_oracle.h

@@ -14,6 +14,10 @@

#include "media/capture/content/video_capture_oracle.h"

#include "media/capture/video/video_capture_device.h"

+namespace tracked_objects {

+class Location;

+} // namespace tracked_objects

namespace media {

struct VideoCaptureParams;

@@ -63,7 +67,8 @@ class MEDIA_EXPORT ThreadSafeCaptureOracle

void Stop();

// Signal an error to the client.

- void ReportError(const std::string& reason);

+ void ReportError(const tracked_objects::Location& from_here,

+ const std::string& reason);

private:

friend class base::RefCountedThreadSafe<ThreadSafeCaptureOracle>;