Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1418253002: switch cpu flags to 0 for unitialized to avoid compare (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin, fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : bump chromium to lkgr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/cpu_id.h View 2 chunks +2 lines, -3 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/cpu_id.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
fbarchard1
5 years, 1 month ago (2015-10-23 17:35:47 UTC) #1
harryjin
lgtm
5 years, 1 month ago (2015-10-23 17:51:40 UTC) #2
fbarchard1
Committed patchset #2 (id:20001) manually as 1502832a70f886829840a8071d90da9bbf7a7bce (presubmit successful).
5 years, 1 month ago (2015-10-23 17:57:46 UTC) #3
fbarchard
5 years, 1 month ago (2015-10-23 21:32:31 UTC) #5
Message was sent while issue was closed.
saves 1 byte per call

  00000074: A1 00 00 00 00     mov         eax,dword ptr [_cpu_info_]
  00000079: 83 F8 01           cmp         eax,1
  0000007C: 75 08              jne         00000086
  0000007E: E8 00 00 00 00     call        _InitCpuFlags
  00000086: A8 40              test        al,40h
  00000088: 74 21              je          000000AB


  00000074: A1 00 00 00 00     mov         eax,dword ptr [_cpu_info_]
  00000079: 85 C0              test        eax,eax
  0000007B: 75 05              jne         00000082
  0000007D: E8 00 00 00 00     call        _InitCpuFlags
  00000082: A8 40              test        al,40h
  00000084: 75 0C              jne         00000092

Powered by Google App Engine
This is Rietveld 408576698