Issue 1418253002: switch cpu flags to 0 for unitialized to avoid compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1418253002: switch cpu flags to 0 for unitialized to avoid compare (Closed)

Created:
5 years, 1 month ago by fbarchard1

Modified:
5 years, 1 month ago

Reviewers:
harryjin, fbarchard

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

More Reviews

Description

switch cpu flags to 0 for unitialized to avoid compare R=harryjin@google.com BUG=libyuv:512 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/1502832a70f886829840a8071d90da9bbf7a7bce

Patch Set 1 #

Patch Set 2 : bump chromium to lkgr #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	README.chromium	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/libyuv/cpu_id.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	include/libyuv/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/cpu_id.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

fbarchard1

Committed patchset #2 (id:20001) manually as 1502832a70f886829840a8071d90da9bbf7a7bce (presubmit successful).

5 years, 1 month ago (2015-10-23 17:57:46 UTC) #3

fbarchard

5 years, 1 month ago (2015-10-23 21:32:31 UTC) #5

Message was sent while issue was closed.

saves 1 byte per call

  00000074: A1 00 00 00 00     mov         eax,dword ptr [_cpu_info_]
  00000079: 83 F8 01           cmp         eax,1
  0000007C: 75 08              jne         00000086
  0000007E: E8 00 00 00 00     call        _InitCpuFlags
  00000086: A8 40              test        al,40h
  00000088: 74 21              je          000000AB


  00000074: A1 00 00 00 00     mov         eax,dword ptr [_cpu_info_]
  00000079: 85 C0              test        eax,eax
  0000007B: 75 05              jne         00000082
  0000007D: E8 00 00 00 00     call        _InitCpuFlags
  00000082: A8 40              test        al,40h
  00000084: 75 0C              jne         00000092

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages