Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1418213010: [turbofan] Initial support for keyed access to fast JSArrays. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial support for keyed access to fast JSArrays. This adds some initial support for keyed element access to fast, non-holey JSArray objects. Also renames PropertyAccessInfoFactory to AccessInfoFactory and PropertyAccessMode to AccessMode. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/1195b0e24de6d6c0a343d444fee68e9f63e022e7 Cr-Commit-Position: refs/heads/master@{#31717}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -553 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/compiler/access-info.h View 4 chunks +39 lines, -13 lines 0 comments Download
A + src/compiler/access-info.cc View 1 13 chunks +85 lines, -33 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 4 chunks +9 lines, -7 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 14 chunks +277 lines, -18 lines 0 comments Download
D src/compiler/property-access-info.h View 1 chunk +0 lines, -120 lines 0 comments Download
D src/compiler/property-access-info.cc View 1 chunk +0 lines, -358 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-02 13:15:42 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the initial version of the keyed element access. Please take a look. ...
5 years, 1 month ago (2015-11-02 13:16:23 UTC) #2
Jarin
lgtm. let's see how we can cope with monster graphs... https://codereview.chromium.org/1418213010/diff/1/src/compiler/access-info.cc File src/compiler/access-info.cc (right): https://codereview.chromium.org/1418213010/diff/1/src/compiler/access-info.cc#newcode25 ...
5 years, 1 month ago (2015-11-02 14:10:00 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1418213010/diff/1/src/compiler/access-info.cc File src/compiler/access-info.cc (right): https://codereview.chromium.org/1418213010/diff/1/src/compiler/access-info.cc#newcode25 src/compiler/access-info.cc:25: // return map->IsJSObjectMap() && !map->has_dictionary_elements() && On 2015/11/02 14:10:00, ...
5 years, 1 month ago (2015-11-02 17:25:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418213010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418213010/20001
5 years, 1 month ago (2015-11-02 17:28:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-02 18:29:51 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 18:30:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1195b0e24de6d6c0a343d444fee68e9f63e022e7
Cr-Commit-Position: refs/heads/master@{#31717}

Powered by Google App Engine
This is Rietveld 408576698