Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1418213007: Include stdio.h for fwrite support (Closed)

Created:
5 years, 1 month ago by landell
Modified:
5 years, 1 month ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include stdio.h for fwrite support BUG= Committed: https://crrev.com/a57ef11af47229209c17fdbfe30d30196dd9635f Cr-Commit-Position: refs/heads/master@{#31669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/log-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
landell
Small include fix. @reviewers: PTAL
5 years, 1 month ago (2015-10-27 14:32:03 UTC) #3
Dan Ehrenberg
I don't understand; where does fwrite get used? Is there a build that's failing?
5 years, 1 month ago (2015-10-27 16:32:37 UTC) #4
landell
On 2015/10/27 16:32:37, Dan Ehrenberg wrote: > I don't understand; where does fwrite get used? ...
5 years, 1 month ago (2015-10-28 07:46:52 UTC) #5
landell
I really like to get this in if possible and I thought it was an ...
5 years, 1 month ago (2015-10-29 08:31:42 UTC) #6
Dan Ehrenberg
lgtm Sorry for the delay, I see that fwrite was already there so this looks ...
5 years, 1 month ago (2015-10-29 18:03:55 UTC) #7
landell
Thanks
5 years, 1 month ago (2015-10-30 07:43:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418213007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418213007/1
5 years, 1 month ago (2015-10-30 07:44:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 08:03:14 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 08:03:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a57ef11af47229209c17fdbfe30d30196dd9635f
Cr-Commit-Position: refs/heads/master@{#31669}

Powered by Google App Engine
This is Rietveld 408576698